Keep wallet bind and P2P ports in .env; tighten installer heuristics - #4
Merged
Conversation
Keep localhost-only wallet RPC and custom P2P ports in .env instead of compose edits. Drop unused FEE_RECIPIENT, require Arch before Omarchy heuristics, and confirm before replacing distro Docker packages. Co-authored-by: David Feder <DavidFeder@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the follow-ups from the repo review: make the LAN/localhost wallet bind and P2P ports survive
git pull, stop advertising an unused validator setting, and make the installer less eager to mis-detect Omarchy or silently replace distro Docker.Changes
HTTP_ADDR/WS_ADDRin.env— localhost-only wallet RPC is nowHTTP_ADDR=127.0.0.1+WS_ADDR=127.0.0.1and./restart.sh. Editingdocker-compose.ymlwas a git-pull trap..env—GETH_P2P_PORT,BEACON_P2P_TCP_PORT,BEACON_P2P_UDP_PORT. Installer UFW rules and port checks follow them.FEE_RECIPIENTfrom.env.example(this stack does not run a validator).~/.local/share/omarchyon Ubuntu cannot steal the Debian Docker CE path.PULSE_ALLOW_DOCKER_CE=1) whendocker.io/ distro Compose /podman-dockeris already installed.geth attach --exec eth.chainId(alpine image has geth, not curl). Beacon still usesdepends_on: gethwithoutservice_healthyso a probe mismatch cannot dead-lock first boot.status.shprints bind mode, running image refs, and “do not send transactions yet” while either client is still syncing.LAN wallet RPC on
0.0.0.0remains the default.Test plan
bash tests/test_common.shbash tests/test_beacon_flags.sh(source/README contracts; compose parse when Docker is present)bash tests/test_image_pins.shshellcheck -xon all scripts (same command as CI)tests / scriptson this PR