Support Template Strings for log messages (#1397)#1398
Conversation
TurtleOrangina
force-pushed
the
support_template_strings
branch
2 times, most recently
from
8ebac5d to
5bcc344
Compare
|
Thank you for this initial implementation. This seems like an excellent solution to compensate for the planned removal of Please allow me not to merge this PR immediately because I want to think a little about possible integrations of t-strings, but it seems very fine to me as is. |
|
Of course! Let me know if you want any changes. |
|
2 month reminder :). I read in a different PR that you are working on some larger refactoring, but wouldn't it make sense to get the simpler things that are already ready merged and maybe make a minor release with them? I would sure enjoy the ability to use |
|
Hi! Just checking in to see if there are any updates on this PR. It would be a handy addition for a project I’m currently working on. Thanks! |
|
Sorry for the delay... I'll test it, merge it and publish a new release by the end of the month. |
Delgan
force-pushed
the
support_template_strings
branch
from
5bcc344 to
33adce0
Compare
Delgan
force-pushed
the
support_template_strings
branch
3 times, most recently
from
4df1e09 to
33ab52a
Compare
Notably: - Fix support for t-strings with `opt(colors=True)` - Handle nested t-strings properly - Implement formatting of t-string in tracebacks (new tokens) - Update the type hints stub to accept t-strings - Mention t-strings in documentation - Add many more unit tests in dedicated file
Delgan
force-pushed
the
support_template_strings
branch
from
33ab52a to
fcee187
Compare
|
Finally merged this. Thanks for the contribution and sorry for the long wait. This feature wasn't as trivial as it might seem, and required a subsequent commit, see 3fb23a4. But everything should work properly. |
3 participants
Implements support for python 3.14 template strings:
Will evaluate lazily, e.g. if the minimum log level means no debug messages are logged, the large_obj will not be converted to string.