feat: add custom user icon file support and improve favicon reliability - #71
Open
ali-mirsalari wants to merge 1 commit into
Open
feat: add custom user icon file support and improve favicon reliability#71ali-mirsalari wants to merge 1 commit into
ali-mirsalari wants to merge 1 commit into
Conversation
Add the ability to select a custom image file (PNG, JPG, SVG, ICO) as a permanent widget icon, independent of system icon themes or internet connectivity. - Add customUserIconPath config entry for persistent user icon file path - Add file picker with preview in Appearance settings under Custom icon mode - Add radio toggle between System Icon and Custom File sources - Handle file:// URIs in CompactRepresentation icon resolution Improve favicon handling for poor or no internet connectivity: - Add fallback timeout timer (5s) for stalled favicon fetches - Fall back to cached lastFavIcon when no new favicon is found - Fall back to adaptive logo when favicon mode has no favicon available - Add onStatusChanged handler to recover from failed icon loads - Fix undefined icon reference to use webview.icon in checkAndUpdateFavicon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the ability to select a custom image file (PNG, JPG, SVG, ICO) as a permanent widget icon, independent of system icon themes or internet connectivity.
Improve favicon handling for poor or no internet connectivity: