feat(call-notes): implement enrichment and knowledge integration - #350
Open
EricLiu2795 wants to merge 12 commits into
Open
feat(call-notes): implement enrichment and knowledge integration#350EricLiu2795 wants to merge 12 commits into
EricLiu2795 wants to merge 12 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the Call Notes enrichment and knowledge-integration lane.
AI enrichment
Adds deterministic/versioned enrichment prompting.
Adds structured proposal generation and semantic transcript/Bookmark provenance validation.
Adds generic optional/defaulted Zod structured-output compatibility.
Validated through a real Kimi K2.6 smoke using the existing OpenAI-compatible model path.
Knowledge integration
Adds KnowledgeNoteSink over the existing LaunchStack Notes/embedding path.
Adds current-revision and knowledge-eligibility validation.
Adds race-safe embedding replacement for delayed/stale jobs.
Filters private/knowledge-disabled Call Notes from company retrieval.
Supports Notes-only company retrieval and preserves Call Note RAG metadata.
Validation
8 Call Notes suites / 73 tests passing.
34 structured-output regression tests passing.
Web and adapters typechecks passing.
Integration boundary
This PR intentionally does not implement the Call Notes application lifecycle. The application layer remains responsible for:
constructing production EnrichmentInput;
enrichment-run persistence and failure handling;
proposal review / Accept / Reject;
base-revision conflict handling;
canonical Call Note revision creation;
invoking KnowledgeNoteSink after canonical lifecycle changes.
See docs/CALL-NOTES-005-HANDOFF.md for the full architecture and handoff.