Unbreak main: route export from #364, Docker manifests for both new bricks - #367
Open
Deodat-Lawson wants to merge 1 commit into
Open
Unbreak main: route export from #364, Docker manifests for both new bricks#367Deodat-Lawson wants to merge 1 commit into
Deodat-Lawson wants to merge 1 commit into
Conversation
…ker manifests Main went red when PR #364 merged at its conflict-resolution commit, before the CI fixes landed on the branch; #362 then stacked a second latent failure on top. Two causes, both fixed here: - next build rejects non-handler exports from route modules (a check plain tsc does not run): OAUTH_STATE_COOKIE moves from the oauth start route into services/google-drive/config, and the callback stops importing from a sibling route file. Fixes the CI `build` job, both Docker image builds, and the Vercel deploy. - the worker and web Dockerfiles enumerate workspace package manifests for their install layer; BOTH new bricks were missing. packages/google-drive (from #364) is what killed compose-smoke ("Cannot find package 'zod'"), and packages/document-conversion-engine (from #362) would have failed the web image build the same way next. Both added to all three Dockerfiles. Verified: SKIP_ENV_VALIDATION next build compiles clean on this branch; google-drive package tests 13/13. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
next buildrejects non-handler exports from route modules — a validation plaintsc --noEmitnever runs — soOAUTH_STATE_COOKIEmoves from the OAuth start route intoservices/google-drive/config, and the callback no longer imports from a sibling route file. Fixes thebuildjob, both Docker image builds, and the Vercel deploy.packages/google-drive(Drive-linked files: edit PDFs and Word docs via Google Drive sync (Phase 1) #364) is what killed compose-smoke (Cannot find package 'zod'), andpackages/document-conversion-engine(Gotenberg PDF rendering: one owner for every PDF the product ships (ADR-009) #362) would have failed the web image build identically next. Both added to all three Dockerfiles.Related
Follow-up to #364 and #362.
Checklist
pnpm checkpasses (lint + typecheck)pnpm --filter @launchstack/web testpasses (unchanged by this diff; google-drive package tests 13/13)Testing
SKIP_ENV_VALIDATION=1 pnpm --filter @launchstack/web buildcompiles clean on this branch (it fails on main with the route-type error).Notes for reviewers
Six files, 15 insertions. The Dockerfile manifest list is a recurring trap — every new workspace package must be added in three places; possibly worth generating that layer from
pnpm-workspace.yamlin a follow-up.🤖 Generated with Claude Code
Note
Low Risk
Infrastructure and module-export fixes with no change to OAuth behavior or runtime auth logic beyond where the constant is defined.
Overview
Restores main after follow-on breakage from the Google Drive and document-conversion workspace packages.
Next.js build:
OAUTH_STATE_COOKIEis no longer exported from the Google OAuth start route. It lives inserver/services/google-drive/configwith a short note that route modules may only export handlers—somethingnext buildenforces but plain typecheck does not. The callback route imports the cookie name from config instead of the sibling route file.Docker install layers: The manifest
COPYlists inapps/web/Dockerfile,apps/web/Dockerfile.prebuilt, andapps/worker/Dockerfilenow includepackages/google-driveandpackages/document-conversion-engineso filteredpnpm install --frozen-lockfileresolves those workspace deps (fixing compose-smoke / image build failures from missing packages likezod).Reviewed by Cursor Bugbot for commit f25fa08. Bugbot is set up for automated code reviews on this repo. Configure here.