Fix main's build and compose-smoke: route-file export, Docker workspace manifests - #368
Open
Deodat-Lawson wants to merge 1 commit into
Open
Fix main's build and compose-smoke: route-file export, Docker workspace manifests#368Deodat-Lawson wants to merge 1 commit into
Deodat-Lawson wants to merge 1 commit into
Conversation
…fests Two failures #364 left latent (its own CI never reached these jobs; this branch is the first past `check`): - next build rejected the connectors start route: Next.js route files may only export handlers and route config, and OAUTH_STATE_COOKIE was a bare constant export the callback imported across routes. It now lives in server/services/google-drive/config, imported by both legs. Verified: `next build` exits 0. - The worker crash-looped in compose-smoke on ERR_MODULE_NOT_FOUND for zod from packages/google-drive: neither Dockerfile copied the two newest workspace manifests before `pnpm install`, so those packages got no node_modules links. Both Dockerfiles now list google-drive and document-conversion-engine (the latter was the same latent bomb for the web image). Verified: image rebuilt, wire.ts imports cleanly inside it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
e4dbc591; the CI-fix commitb019d46dlanded on the branch minutes later). Without it, main'sbuildandcompose-smokejobs fail.next buildrejects the Drive OAuth start route — Next.js route files may only export handlers and route config, andOAUTH_STATE_COOKIEwas a bare constant export that the callback imported across routes. It now lives inserver/services/google-drive/config, imported by both legs. (tsc --noEmitcan't catch this; onlynext build's route typegen does — which is why Drive-linked files: edit PDFs and Word docs via Google Drive sync (Phase 1) #364'scheckjob was green.)ERR_MODULE_NOT_FOUND: zodfrompackages/google-drive/src/wire.ts— neither Dockerfile copied the two newest workspace manifests beforepnpm install, so those packages got no dependency links. Both Dockerfiles now listgoogle-driveanddocument-conversion-engine(the latter was the same latent bomb waiting for the web image).Related
Follow-up to #362 (merged with these fixes still on the branch); fixes fallout from #364.
Checklist
pnpm checkpasses (lint + typecheck)pnpm --filter @launchstack/web testpassesTesting
SKIP_ENV_VALIDATION=1 pnpm --filter @launchstack/web buildexits 0 (the exactbuildgate that fails on main).packages/google-drive/src/wire.ts(the exact module in the crash loop) andpackages/document-conversion-engine/src/index.tsboth import cleanly under tsx.Notes for reviewers
Same content as
b019d46don the merged #362 branch, cherry-picked onto main. Merging this should turn main'sbuildandcompose-smokegreen again.🤖 Generated with Claude Code
Note
Low Risk
Build/CI and import-location fixes with no intended runtime behavior change beyond restoring green builds and worker startup.
Overview
Unblocks main CI by fixing two unrelated breakages from recent Google Drive / workspace package work.
next build: MovesOAUTH_STATE_COOKIEout of the OAuth start route intoserver/services/google-drive/config, with start and callback importing it from there. Route modules may only export handlers and route config; the extra constant export caused the build gate to fail (typecheck alone does not catch this).Docker
compose-smoke: Addsdocument-conversion-engineandgoogle-drivepackage.jsoncopies to the web and worker images beforepnpm install, so workspace packages link correctly and runtime no longer hits missing deps (e.g.zodfromgoogle-drive).Reviewed by Cursor Bugbot for commit 4fab809. Bugbot is set up for automated code reviews on this repo. Configure here.