Skip to content

Fix main's build and compose-smoke: route-file export, Docker workspace manifests - #368

Open
Deodat-Lawson wants to merge 1 commit into
mainfrom
claude/gotenberg-ci-fixes-91b57d
Open

Fix main's build and compose-smoke: route-file export, Docker workspace manifests#368
Deodat-Lawson wants to merge 1 commit into
mainfrom
claude/gotenberg-ci-fixes-91b57d

Conversation

@Deodat-Lawson

@Deodat-Lawson Deodat-Lawson commented Aug 30, 2026

Copy link
Copy Markdown
Owner

Summary

  • Carries the one commit stranded when Gotenberg PDF rendering: one owner for every PDF the product ships (ADR-009) #362 was merged (its head was e4dbc591; the CI-fix commit b019d46d landed on the branch minutes later). Without it, main's build and compose-smoke jobs fail.
  • build: next build rejects the Drive OAuth start route — Next.js route files may only export handlers and route config, and OAUTH_STATE_COOKIE was a bare constant export that the callback imported across routes. It now lives in server/services/google-drive/config, imported by both legs. (tsc --noEmit can't catch this; only next build's route typegen does — which is why Drive-linked files: edit PDFs and Word docs via Google Drive sync (Phase 1) #364's check job was green.)
  • compose-smoke: the worker crash-looped on ERR_MODULE_NOT_FOUND: zod from packages/google-drive/src/wire.ts — neither Dockerfile copied the two newest workspace manifests before pnpm install, so those packages got no dependency links. Both Dockerfiles now list google-drive and document-conversion-engine (the latter was the same latent bomb waiting for the web image).

Related

Follow-up to #362 (merged with these fixes still on the branch); fixes fallout from #364.

Checklist

  • pnpm check passes (lint + typecheck)
  • pnpm --filter @launchstack/web test passes
  • Changeset — not needed: no publishable package source changed
  • New env vars — none
  • UI changes — none
  • Docs — no behavior change beyond CI

Testing

  • SKIP_ENV_VALIDATION=1 pnpm --filter @launchstack/web build exits 0 (the exact build gate that fails on main).
  • Worker image rebuilt from the patched Dockerfile; inside it, packages/google-drive/src/wire.ts (the exact module in the crash loop) and packages/document-conversion-engine/src/index.ts both import cleanly under tsx.

Notes for reviewers

Same content as b019d46d on the merged #362 branch, cherry-picked onto main. Merging this should turn main's build and compose-smoke green again.

🤖 Generated with Claude Code


Note

Low Risk
Build/CI and import-location fixes with no intended runtime behavior change beyond restoring green builds and worker startup.

Overview
Unblocks main CI by fixing two unrelated breakages from recent Google Drive / workspace package work.

next build: Moves OAUTH_STATE_COOKIE out of the OAuth start route into server/services/google-drive/config, with start and callback importing it from there. Route modules may only export handlers and route config; the extra constant export caused the build gate to fail (typecheck alone does not catch this).

Docker compose-smoke: Adds document-conversion-engine and google-drive package.json copies to the web and worker images before pnpm install, so workspace packages link correctly and runtime no longer hits missing deps (e.g. zod from google-drive).

Reviewed by Cursor Bugbot for commit 4fab809. Bugbot is set up for automated code reviews on this repo. Configure here.

…fests

Two failures #364 left latent (its own CI never reached these jobs; this
branch is the first past `check`):

- next build rejected the connectors start route: Next.js route files may
  only export handlers and route config, and OAUTH_STATE_COOKIE was a bare
  constant export the callback imported across routes. It now lives in
  server/services/google-drive/config, imported by both legs. Verified:
  `next build` exits 0.
- The worker crash-looped in compose-smoke on ERR_MODULE_NOT_FOUND for zod
  from packages/google-drive: neither Dockerfile copied the two newest
  workspace manifests before `pnpm install`, so those packages got no
  node_modules links. Both Dockerfiles now list google-drive and
  document-conversion-engine (the latter was the same latent bomb for the
  web image). Verified: image rebuilt, wire.ts imports cleanly inside it.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@vercel

vercel Bot commented Aug 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
launch-stack Error Error Aug 30, 2026 5:31pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
pdr-ai-v2 Ignored Ignored Aug 30, 2026 5:31pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant