[Tests] Improve branch coverage for BaseGui, GuiManager, and Slot

[DiamondDagger590]

Summary

• Add 3 new tests to BaseGuiTest covering previously untested branches: refreshGUI() default method, handleClickEvent() with allowBottomInventoryClick=true, and handleClickEvent() when corePlayer is not found in PlayerManager
• Replace 1 generic event-firing test in GuiManagerTest with 3 targeted tests covering KeyedGui branching in trackPlayerGui(): non-keyed gui, keyed gui with present key, and keyed gui with empty key (using ArgumentCaptor for precise assertions)

Test plan

• All existing tests pass (./gradlew test — BUILD SUCCESSFUL)
• JaCoCo coverage report generated successfully
• Testing audit persona applied — no concerns found
• No production code changes

---

Generated by Claude Code

Summary by CodeRabbit

• Tests
  • Added coverage to verify GUI refreshes repaint correctly.
  • Added tests for inventory click handling, including permitted bottom-inventory clicks and missing players.
  • Expanded GUI event testing to confirm keys are reported correctly for keyed and non-keyed interfaces.

[github-actions]

Claude finished @DiamondDagger590's task in 2m 4s —— View job

---

No blocking issues found

This is a test-only PR (no production code changes) adding targeted branch coverage to BaseGuiTest (refreshGUI(), handleClickEvent() with allowBottomInventoryClick=true, and the "player not in PlayerManager" path) and replacing a generic event-firing test in GuiManagerTest with three precise KeyedGui-branch tests using ArgumentCaptor.

• Gather context (PR diff, changed files)
• Route to review lenses — review-testing (primary lens for test-file changes) and review-extensibility (path matches src/**/gui/**); production-code-only lenses (architecture, error-handling, performance, security) skipped since no src/main files changed
• Fan out to persona subagents
• Consolidate findings
• Post final review

Findings: none. Both lenses returned clean — new tests correctly follow the methodUnderTest_expectedOutcome_whenCondition naming convention, carry descriptive @DisplayNames, exercise real assertions against the exact new branches, and appropriately avoid MockBukkit/thread-safety machinery that isn't needed here (no RegistryResetExtension or ManagedExecutorExtension concerns apply). No extensibility impact since no public API or production code changed.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: QUIET

Plan: Pro Plus

Run ID: a5733d8a-615c-4563-a9e1-b7d02072eb31

📥 Commits

Reviewing files that changed from the base of the PR and between 0fbf220 and da4b41f.

📒 Files selected for processing (2)

• src/test/java/com/diamonddagger590/mccore/gui/BaseGuiTest.java
• src/test/java/com/diamonddagger590/mccore/gui/GuiManagerTest.java

---

📝 Walkthrough

Walkthrough

The PR adds GUI tests for refreshGUI() repainting, inventory click cancellation behavior, missing-player handling, and CoreGuiOpenEvent GUI key presence semantics.

Changes

GUI behavior test coverage

Layer / File(s)	Summary
BaseGui behavior coverage src/test/java/com/diamonddagger590/mccore/gui/BaseGuiTest.java	Tests verify that refreshGUI() invokes paintInventory() and that applicable inventory click events remain uncancelled.
GUI open event payloads src/test/java/com/diamonddagger590/mccore/gui/GuiManagerTest.java	Tests capture CoreGuiOpenEvent and verify GUI key presence for non-keyed, keyed, and empty-key GUIs.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• DiamondDagger590/McCore#36: Also tests GuiManager.trackPlayerGui and CoreGuiOpenEvent semantics.
• DiamondDagger590/McCore#42: Adds related coverage for CoreGuiOpenEvent.getGuiKey().
• DiamondDagger590/McCore#61: Adds related BaseGui click-event assertions.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: added tests to improve branch coverage for BaseGui and GuiManager.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/eager-thompson-kueynb

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}