[Tests] Add unit tests for ReloadableContent subclasses (Boolean, Double, Integer, String, List, Set, StringList)

[DiamondDagger590]

Summary

• Adds dedicated unit tests for all 7 previously untested ReloadableContent subclasses: ReloadableBoolean, ReloadableDouble, ReloadableInteger, ReloadableString, ReloadableList, ReloadableSet, and ReloadableStringList
• Each test file covers both constructor variants (callback-only and explicit content), reload behavior after YAML modification, and edge cases
• Edge cases tested include: zero/negative values, empty collections, missing YAML keys, type conversion functions (e.g., string-to-integer parsing), and set deduplication from duplicate YAML entries

Details

These 7 classes had zero test coverage and were not covered by any open PR. While they are thin wrappers around ReloadableContent, the tests verify:

1. Constructor wiring — the Section::getBoolean, Section::getInt, etc. method references are correctly composed
2. Explicit content override — the two-arg constructor correctly defers loading until reloadContent() is called
3. Missing YAML key behavior — documents what happens when a config key is absent (returns type defaults: 0, 0.0, false, null, empty list/set)
4. Collection conversion composition — ReloadableList and ReloadableSet correctly apply user-provided conversion functions to transform YAML string lists into typed collections

Test plan

• All 7 new test files pass (./gradlew test)
• Full test suite passes with no regressions
• Testing audit persona reviewed — all findings addressed (missing-key tests, negative doubles, zero integers)
• No production code changes

---

Generated by Claude Code

Summary by CodeRabbit

• Tests
  • Added comprehensive coverage for reloadable lists, sets, strings, booleans, integers, and decimals.
  • Verified YAML loading, missing values, defaults, explicit overrides, type conversion, and value transformations.
  • Added checks confirming configuration values update correctly after YAML changes.
  • Verified duplicate removal for reloadable sets.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: QUIET

Plan: Pro Plus

Run ID: ddb1782b-67ed-4806-b7a7-3d13e8881a42

📥 Commits

Reviewing files that changed from the base of the PR and between 0fbf220 and 120bbd3.

📒 Files selected for processing (7)

• src/test/java/com/diamonddagger590/mccore/configuration/collection/ReloadableListTest.java
• src/test/java/com/diamonddagger590/mccore/configuration/collection/ReloadableSetTest.java
• src/test/java/com/diamonddagger590/mccore/configuration/collection/ReloadableStringListTest.java
• src/test/java/com/diamonddagger590/mccore/configuration/common/ReloadableBooleanTest.java
• src/test/java/com/diamonddagger590/mccore/configuration/common/ReloadableDoubleTest.java
• src/test/java/com/diamonddagger590/mccore/configuration/common/ReloadableIntegerTest.java
• src/test/java/com/diamonddagger590/mccore/configuration/common/ReloadableStringTest.java

---

📝 Walkthrough

Walkthrough

Added JUnit tests for reloadable scalar and collection configuration values. The tests cover YAML loading, defaults, explicit content, transformations, duplicate removal, YAML updates, and reloadContent() behavior.

Changes

Reloadable content tests

Layer / File(s)	Summary
Scalar loading and reload tests src/test/java/com/diamonddagger590/mccore/configuration/common/ReloadableBooleanTest.java, src/test/java/com/diamonddagger590/mccore/configuration/common/ReloadableDoubleTest.java, src/test/java/com/diamonddagger590/mccore/configuration/common/ReloadableIntegerTest.java, src/test/java/com/diamonddagger590/mccore/configuration/common/ReloadableStringTest.java	Tests cover scalar YAML values, missing-key defaults, explicit content, YAML updates, and reload behavior.
Collection loading and transformation tests src/test/java/com/diamonddagger590/mccore/configuration/collection/ReloadableListTest.java, src/test/java/com/diamonddagger590/mccore/configuration/collection/ReloadableSetTest.java, src/test/java/com/diamonddagger590/mccore/configuration/collection/ReloadableStringListTest.java	Tests cover collection loading, empty and missing keys, explicit content, transformations, integer conversion, set deduplication, YAML updates, and reload behavior.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

• DiamondDagger590/McCore#28: Expands tests for the same ReloadableContent subtypes and related YAML and reload behavior.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the added unit tests for the listed ReloadableContent subclasses.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/eager-thompson-izfkke

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Claude finished @DiamondDagger590's task in 3m 26s —— View job

---

Claude PR Review

Verdict: No blocking issues found — 4 nits

This PR is test-only (no src/main changes), so only the review-testing lens applies. The 7 new test files give solid coverage of both constructor variants, reload behavior, and missing-key defaults for all 7 ReloadableContent subclasses; nothing here risks the framework's public API or behavior.

Nits (4)

• src/test/java/com/diamonddagger590/mccore/configuration/common/ReloadableStringTest.java:46 — assertEquals(null, content.getContent()) should be assertNull(content.getContent()) for a clearer failure message and to match JUnit 5 idiom.
• src/test/java/com/diamonddagger590/mccore/configuration/common/ReloadableBooleanTest.java:13 — unused import static org.junit.jupiter.api.Assertions.assertEquals; (only assertTrue/assertFalse are used in this class).
• ReloadableIntegerTest.java / ReloadableDoubleTest.java — no boundary case for Integer.MAX_VALUE / Double.MAX_VALUE, only happy-path/zero/negative values.
• ReloadableIntegerTest.java / ReloadableDoubleTest.java — no case for a non-numeric string at the route (e.g. count: "abc") to document whether BoostedYAML falls back to a default or throws.

• Gather context (PR diff, changed files)
• Route to review lenses — only review-testing applies (test-only PR)
• Run review-testing lens
• Consolidate findings
• Post final review