Skip to content

ViSR: fix sizing of plots, get real feed from tomo camera - #176

Merged
Abigail-Yates merged 20 commits into
mainfrom
ay/visr-grid-plots
Aug 28, 2026
Merged

ViSR: fix sizing of plots, get real feed from tomo camera#176
Abigail-Yates merged 20 commits into
mainfrom
ay/visr-grid-plots

Conversation

@Abigail-Yates

@Abigail-Yates Abigail-Yates commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

This PR combines / replaces #158 #164 and #169 .

  • Implementing pva to video to get the real camera stream: https://github.com/diamondlightsource/pva-to-video/pkgs/container/pva-to-video
  • Plot sizing fixes:
    • Plots fill their parent box
    • SliceView plot resizes correctly when the controls drawer is opened and closed
    • Plots resize correctly when the window size is changed
  • The size of the plots are calculated to use the remaining space after the controls drawer is opened
    --> i.e. when expanded, the controls drawer should show as full sized and the 'plots' should fill the remaining space without needing a scroll bar... until a certain minimum height for the plots is met (at which point a scroll bar appears)

// Camera view
// ---------------------------------------------------------------------------

function CamPva() {

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomkane-dls quick question - should this be in a different file? or should we be using the webcam from cs-web-lib as Emily suggested?
Is this intentional to keep it simple for testing?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to keep for simple testing so we always have an image to check the UI behaviour, but we will see the PVA stream if its working. We can remove later and work with Emily to use something like the Webcam later.

@Abigail-Yates
Abigail-Yates marked this pull request as ready for review August 28, 2026 07:54
@Abigail-Yates
Abigail-Yates merged commit 9b07d6a into main Aug 28, 2026
1 of 2 checks passed
@Abigail-Yates
Abigail-Yates deleted the ay/visr-grid-plots branch August 28, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ViSR: Update Image Plots - ensure they grow to fill parent Box properly

2 participants