ViSR: fix sizing of plots, get real feed from tomo camera - #176
Merged
Conversation
This was referenced Aug 27, 2026
Abigail-Yates
commented
Aug 27, 2026
| // Camera view | ||
| // --------------------------------------------------------------------------- | ||
|
|
||
| function CamPva() { |
Collaborator
Author
There was a problem hiding this comment.
@tomkane-dls quick question - should this be in a different file? or should we be using the webcam from cs-web-lib as Emily suggested?
Is this intentional to keep it simple for testing?
Contributor
There was a problem hiding this comment.
Just to keep for simple testing so we always have an image to check the UI behaviour, but we will see the PVA stream if its working. We can remove later and work with Emily to use something like the Webcam later.
tomkane-dls
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR combines / replaces #158 #164 and #169 .
--> i.e. when expanded, the controls drawer should show as full sized and the 'plots' should fill the remaining space without needing a scroll bar... until a certain minimum height for the plots is met (at which point a scroll bar appears)