Skip to content

mx-bluesky#1765 Refactor grid parameters - #2112

Open
rtuck99 wants to merge 4 commits into
mainfrom
mx-bluesky_1765_grid_scan_params_refactor
Open

mx-bluesky#1765 Refactor grid parameters#2112
rtuck99 wants to merge 4 commits into
mainfrom
mx-bluesky_1765_grid_scan_params_refactor

Conversation

@rtuck99

@rtuck99 rtuck99 commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Part of fix for:

Required by:

See also:

This removes grid_position_to_motor_position(). The function is now part of xrc_result_utils in mx-bluesky.

Instructions to reviewer on how to test:

  1. Tests pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 99.29%. Comparing base (e8b29c8) to head (d01eb56).

Files with missing lines Patch % Lines
...plans/configure_arm_trigger_and_disarm_detector.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2112      +/-   ##
==========================================
- Coverage   99.33%   99.29%   -0.05%     
==========================================
  Files         367      367              
  Lines       14379    14371       -8     
==========================================
- Hits        14284    14270      -14     
- Misses         95      101       +6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rtuck99
rtuck99 marked this pull request as ready for review July 13, 2026 16:31
@rtuck99
rtuck99 requested a review from a team as a code owner July 13, 2026 16:31
@rtuck99
rtuck99 force-pushed the mx-bluesky_1765_grid_scan_params_refactor branch from 490d825 to a6d29c1 Compare July 14, 2026 13:11
@rtuck99
rtuck99 force-pushed the mx-bluesky_1765_grid_scan_params_refactor branch from a6d29c1 to a0ee32a Compare September 2, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant