Floats no longer split the inline flow - #629
Merged
Merged
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
devin-ai-integration
Bot
changed the base branch from
devin/1786122908-taffy-git-dep
to
main
August 7, 2026 20:38
devin-ai-integration
Bot
force-pushed
the
devin/1786127796-float-inline-flow
branch
from
August 7, 2026 20:51
3dfb7ab to
1138c55
Compare
nicoburns
marked this pull request as ready for review
August 7, 2026 21:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split out of #628 per request. Based directly on
mainwith no taffy version change.Node::is_or_contains_blocknow returnsfalsefor floated nodes: floats are blockified by stylo, but they participate in the inline formatting context as out-of-flow inline boxes, so a span containing a float must not force anonymous-block splitting of its inline context. Fixes WPTcss/CSS2/floats/float-in-inline-001/002.htmlandfloats-placement-vertical-001b/001c.xht(in combination with the float support in #625/#628).Link to Devin session: https://app.devin.ai/sessions/2aa49a15ca484966b5b71922bfd2bb58
Requested by: @nicoburns
WPT results
11 newly passing, 5 newly failing (net +6).
Full diff (16 changed tests)
Generated by the WPT workflow.