Skip to content

Floats no longer split the inline flow - #629

Merged
nicoburns merged 1 commit into
mainfrom
devin/1786127796-float-inline-flow
Aug 7, 2026
Merged

Floats no longer split the inline flow#629
nicoburns merged 1 commit into
mainfrom
devin/1786127796-float-inline-flow

Conversation

@nicoburns

@nicoburns nicoburns commented Aug 7, 2026

Copy link
Copy Markdown
Member

Summary

Split out of #628 per request. Based directly on main with no taffy version change.

Node::is_or_contains_block now returns false for floated nodes: floats are blockified by stylo, but they participate in the inline formatting context as out-of-flow inline boxes, so a span containing a float must not force anonymous-block splitting of its inline context. Fixes WPT css/CSS2/floats/float-in-inline-001/002.html and floats-placement-vertical-001b/001c.xht (in combination with the float support in #625/#628).

Link to Devin session: https://app.devin.ai/sessions/2aa49a15ca484966b5b71922bfd2bb58
Requested by: @nicoburns

WPT results

11 newly passing, 5 newly failing (net +6).

Full diff (16 changed tests)
+ Fail => Pass css/CSS2/abspos/static-inside-float-inside-inline.html
+ Fail => Pass css/CSS2/floats-clear/floats-149.xht
+ Fail => Pass css/CSS2/floats/float-in-inline-001.html
+ Fail => Pass css/CSS2/floats/float-in-inline-002.html
- Pass => Fail css/CSS2/floats/float-nowrap-3.html
+ Fail => Pass css/CSS2/floats/float-nowrap-4.html
- Pass => Fail css/CSS2/floats/float-nowrap-9.html
+ Fail => Pass css/CSS2/floats/float-nowrap-hyphen-rewind-1.html
+ Fail => Pass css/CSS2/floats/floats-placement-vertical-001b.xht
+ Fail => Pass css/CSS2/floats/floats-placement-vertical-001c.xht
- Pass => Fail css/CSS2/normal-flow/block-in-inline-float-between-001.xht
- Pass => Fail css/CSS2/visuren/float-inside-inline-between-blocks-1.html
- Pass => Fail css/css-color/inline-opacity-float-child.html
+ Fail => Pass css/css-ruby/empty-ruby-text-container-float.html
+ Fail => Pass css/css-ruby/ruby-base-container-float.html
+ Fail => Pass css/css-ruby/ruby-float-handling-001.html

Generated by the WPT workflow.

@nicoburns nicoburns self-assigned this Aug 7, 2026
@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration
devin-ai-integration Bot changed the base branch from devin/1786122908-taffy-git-dep to main August 7, 2026 20:38
@devin-ai-integration
devin-ai-integration Bot force-pushed the devin/1786127796-float-inline-flow branch from 3dfb7ab to 1138c55 Compare August 7, 2026 20:51
@nicoburns
nicoburns marked this pull request as ready for review August 7, 2026 21:10
@nicoburns
nicoburns merged commit 3b5a74d into main Aug 7, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant