Map the dir attribute with selectors the engine can parse - #650
Open
maurerdietmar wants to merge 1 commit into
Open
Map the dir attribute with selectors the engine can parse#650maurerdietmar wants to merge 1 commit into
maurerdietmar wants to merge 1 commit into
Conversation
The bidi rules in the default stylesheet came from Gecko and match through its internal pseudo-classes (:-moz-dir-attr-rtl and friends), which the servo selector parser does not know. It dropped every one of them, so dir="rtl" set no direction and a page could not switch to right-to-left layout at all, even though the layout side fully supports it. Use the attribute-selector form from the HTML spec's bidi rendering section instead. dir=auto keeps its isolation but not the content-based direction, which needs bidi analysis no selector can express. Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bidi rules in the default stylesheet came from Gecko and match through its internal pseudo-classes (:-moz-dir-attr-rtl and friends), which the servo selector parser does not know. It dropped every one of them, so dir="rtl" set no direction and a page could not switch to right-to-left layout at all, even though the layout side fully supports it.
Use the attribute-selector form from the HTML spec's bidi rendering section instead. dir=auto keeps its isolation but not the content-based direction, which needs bidi analysis no selector can express.
WPT results
3 newly passing, 2 newly failing (net +1).
Full diff (5 changed tests)
Generated by the WPT workflow.