Table: pass calc() cell widths through to Taffy for column sizing - #653
Open
nicoburns wants to merge 1 commit into
Open
Table: pass calc() cell widths through to Taffy for column sizing#653nicoburns wants to merge 1 commit into
nicoburns wants to merge 1 commit into
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes CRASHes in
css/css-values/calc-width-table-auto-1.htmlandcss/css-values/calc-width-table-fixed-1.html(css/css-values: 6 → 4 crashes; the remaining 4 are unrelated).The
matchovertaffy::CompactLengthtags incollect_table_cellscolumn sizing (table.rs:301) hitunreachable!()forcalc()cell widths. Sincetaffy::Dimensioncan only be length, percent, auto or calc, the remaining case is calc; the fix passes theDimensionthrough as the column track sizing function (_ => style.size.width.into()), so Taffy resolves the calc expression against the table's inner width during track sizing — the appropriate basis, which isn't known at column-collection time.Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/a8bd4846bf354f33a6037fffaca1f583
Requested by: @nicoburns
WPT results
1 newly passing, 0 newly failing (net +1), 1 other status change.
Full diff (2 changed tests)
Generated by the WPT workflow.