Skip to content

clip-path: implement closest-corner and farthest-corner shape radii - #654

Merged
nicoburns merged 1 commit into
mainfrom
devin/1786204589-clip-path-corners
Aug 9, 2026
Merged

clip-path: implement closest-corner and farthest-corner shape radii#654
nicoburns merged 1 commit into
mainfrom
devin/1786204589-clip-path-corners

Conversation

@nicoburns

@nicoburns nicoburns commented Aug 8, 2026

Copy link
Copy Markdown
Member

Summary

Fixes CRASHes (todo!()) in css/css-masking/clip-path/clip-path-circle-closest-corner.html and clip-path-circle-farthest-corner.html (2 → 0 crashes; both now PASS).

Implements GenericShapeRadius::ClosestCorner/FarthestCorner in resolve_shape_radius per css-shapes-1: the radius is the distance from the shape's centre to the closest/farthest corner of the reference box, i.e. hypot of the per-axis closest/farthest side distances (min/max of offset and size - offset on each axis, clamped to ≥ 0 for closest-corner when the centre lies outside the box).

Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/a8bd4846bf354f33a6037fffaca1f583
Requested by: @nicoburns

WPT results

2 newly passing, 0 newly failing (net +2).

Full diff (2 changed tests)
+ Crash => Pass css/css-masking/clip-path/clip-path-circle-closest-corner.html
+ Crash => Pass css/css-masking/clip-path/clip-path-circle-farthest-corner.html

Generated by the WPT workflow.

@nicoburns nicoburns self-assigned this Aug 8, 2026
@staging-devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@nicoburns
nicoburns merged commit f4f457a into main Aug 9, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant