Skip to content

[ENG-2098] Materialize Roam-origin markdown into Roam - #1275

Open
sid597 wants to merge 1 commit into
eng-1859-add-roam-import-action-for-selected-shared-nodes-v3from
eng-2098-materialize-roam-origin-markdown-into-roam
Open

[ENG-2098] Materialize Roam-origin markdown into Roam#1275
sid597 wants to merge 1 commit into
eng-1859-add-roam-import-action-for-selected-shared-nodes-v3from
eng-2098-materialize-roam-origin-markdown-into-roam

Conversation

@sid597

@sid597 sid597 commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

Accepts Roam-origin shared nodes in the Roam materializer: the expected full content type is now derived from the node's platform (text/roam+markdown for Roam, text/obsidian+markdown for Obsidian), and Roam-origin full content gets its leading # title heading stripped on import when the first line matches the shared title exactly — otherwise the text is left untouched. The producer format stays unchanged; strip-on-import keeps the validated Roam→Obsidian path as is.

The platform gate in validateSharedNode and isImportableSharedNode in the discovery dialog are removed rather than extended: with both Platform enum values (Roam, Obsidian) now supported, both checks would be dead code by type.

Stacked on #1269 (ENG-1859).

Scope check

  • Ran $scope-check against ENG-2098 and the final diff.
  • Scope beyond Done When: None.

Open in Devin Review

@linear-code

linear-code Bot commented Aug 5, 2026

Copy link
Copy Markdown

ENG-2098

@vercel

vercel Bot commented Aug 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
discourse-graph Ready Ready Preview Aug 5, 2026 7:00am

Request Review

@supabase

supabase Bot commented Aug 5, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@graphite-app

graphite-app Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

PR size/scope check

This PR is over our review-size guideline.

  • Recommended: ~200 lines changed
  • Acceptable limit: up to 400 lines when well-scoped/self-contained
  • Preferred file count: fewer than 5 files

Please split this into smaller PRs unless there is a clear reason the changes need to land together.

If keeping it as one PR, please add a brief justification covering:

  • What single problem this PR solves
  • Why the files/changes are coupled

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

@sid597
sid597 force-pushed the eng-2098-materialize-roam-origin-markdown-into-roam branch from 98a538f to b4c4201 Compare August 5, 2026 06:54
@sid597
sid597 force-pushed the eng-2098-materialize-roam-origin-markdown-into-roam branch from b4c4201 to 090f66c Compare August 5, 2026 06:59
@sid597

sid597 commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 090f66c9ce

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@sid597
sid597 requested a review from maparent August 5, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant