Skip to content

SpecNuts support .net core - #4

Open
0x4D616E75 wants to merge 21 commits into
DonutReport:masterfrom
0x4D616E75:netstandard
Open

SpecNuts support .net core#4
0x4D616E75 wants to merge 21 commits into
DonutReport:masterfrom
0x4D616E75:netstandard

Conversation

@0x4D616E75

Copy link
Copy Markdown

I have updated SpecNuts to use TargetFramework "netstandard2.0". With this changes .net full 4.6.1 and .net core 2.0 are support. I have only tested with .net core on macOS.

@0x4D616E75

Copy link
Copy Markdown
Author

The used CI image use msbuild version 14 (VS2015), is it possible to update CI image to a version which support new project format (VS2017 or VS2019)?

@cosminstirbu

Copy link
Copy Markdown

@williamsia

Can you please review this and push a new Nuget package?

I'm also interested in these changes as we'd like to migrate our Specflow tests to NET Core as well.

Thank you,
Cosmin

@cosminstirbu

cosminstirbu commented Aug 16, 2019

Copy link
Copy Markdown

@0x4D616E75

I have built & integrated the two assemblies (SpecNuts and SpecNuts.Json) from your branch into a netcoreapp2.1 that uses SpecFlow 3.0.225 (with NUnit) and for some reason the event handler from Reporters.FinishedReport += ... is not invoked.

I'm suspecting that it is related to https://github.com/techtalk/SpecFlow/issues/1348 (even if I'm doing the registration in [BeforeTestRun] just as before migrating to netcoreapp2.1 when I was using netframework4.7.1)

Have you've also seen this behavior? Do you have any workaround?

Thanks,
Cosmin

@cosminstirbu

Copy link
Copy Markdown

It looks that I was missing the new specflow.json (also the CopyToOutputDirectory entry from .csproj) - had a closer look at SpecNuts.ApprovalTestSuite and figured it out.

Also I've updated Specflow to "3.1.32-beta" which fixed techtalk/SpecFlow#1348 - not sure if it was related or not though.

Thank you for your work, looking forward to see this merged and released to .nuget so we don't have to reference the actual .dlls any longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants