Dockerfile by temyers · Pull Request #43 · DonutReport/donut

temyers · 2017-09-28T07:53:59Z

Add a Dockerfile for use as a container
Add docker-compose.yml to for containerised build (also updated the build.properties to match the sbt version in the container)
Updated README.md with instructions for using the container.

Container published here:
https://hub.docker.com/u/donutreport/dashboard/

…ing sbt.

cache dependencies for travis build Build container from published version. Will use autobuild on Docker Hub Add instructions for manual Docker deployment

…k for PRs.

temyers · 2017-09-28T09:44:52Z

+
+WORKDIR /app
+
+RUN wget http://repo1.maven.org/maven2/io/magentys/donut/1.0/donut-1.0-one-jar.jar /app/donut.jar


Adding docker to the Travis build, caused test failures due to ordering conflict when reading files.

Therefore building and deploying to DockerHub at the moment would be manual and should use released versions.

Alternatively, we could build the one-jar prior to building the container and copy it in (details are in the README for that)

This line could change to

COPY target/donut*-one-jar.jar /app/donut.jar

temyers · 2017-09-28T09:45:51Z

+
+To run using Docker:
+```
+docker run -v /path/to/your/cucumber-reports:/source -v /path/to/output-report:/output donutreport/donut-docker -n myProjectName [options]


The input and output volumes are required to ensure the folders are available to the container, and aren't lost when the report is generated.

The name of image is incorrect. It should be donutreport/donut-report .

I'll fix this.

This command fails with a donut exception when we pass multiple paths ex: docker run -v /Users/amit/git-repositories/donut/src/test/resources/cuke-and-unit/cuke,/Users/amit/git-repositories/donut/src/test/resources/cuke-and-unit/unit:/source -v /Users/amit/tempd/report:/output donutreport/donut-report -n myProject
0 [main] INFO io.magentys.donut.gherkin.Generator$ - source paths: cucumber:/source
11 [main] INFO io.magentys.donut.gherkin.Generator$ - Cuke path: /source
Exception in thread "main" java.lang.reflect.InvocationTargetException
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:564)
at com.simontuffs.onejar.Boot.run(Boot.java:340)
at com.simontuffs.onejar.Boot.main(Boot.java:166)
Caused by: io.magentys.donut.gherkin.DonutException
at io.magentys.donut.gherkin.Generator$.apply(Generator.scala:39)
at io.magentys.donut.Boot$.delayedEndpoint$io$magentys$donut$Boot$1(Boot.scala:85)

It works for one path(the cucumber path). But it should be able to accept the both cucumber and unit test json paths ex: cucumber:/my/cucumber/path,/my/JUnit/path

I've updated so you need to specify the -s command yourself.
Updated the README

… and fixed the image name typo

amitsha256 · 2017-10-02T08:06:59Z

+
+To run using Docker:
+```
+docker run -v /path/to/your/cucumber-reports:/source -v /path/to/output-report:/output donutreport/donut-docker -n myProjectName [options]


The name of image is incorrect. It should be donutreport/donut-report .

amitsha256 · 2017-10-02T08:17:16Z

+
+To run using Docker:
+```
+docker run -v /path/to/your/cucumber-reports:/source -v /path/to/output-report:/output donutreport/donut-docker -n myProjectName [options]


I'll fix this.

amitsha256 · 2017-10-02T08:49:38Z

+
+To run using Docker:
+```
+docker run -v /path/to/your/cucumber-reports:/source -v /path/to/output-report:/output donutreport/donut-docker -n myProjectName [options]


This command fails with a donut exception when we pass multiple paths ex: docker run -v /Users/amit/git-repositories/donut/src/test/resources/cuke-and-unit/cuke,/Users/amit/git-repositories/donut/src/test/resources/cuke-and-unit/unit:/source -v /Users/amit/tempd/report:/output donutreport/donut-report -n myProject
0 [main] INFO io.magentys.donut.gherkin.Generator$ - source paths: cucumber:/source
11 [main] INFO io.magentys.donut.gherkin.Generator$ - Cuke path: /source
Exception in thread "main" java.lang.reflect.InvocationTargetException
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:564)
at com.simontuffs.onejar.Boot.run(Boot.java:340)
at com.simontuffs.onejar.Boot.main(Boot.java:166)
Caused by: io.magentys.donut.gherkin.DonutException
at io.magentys.donut.gherkin.Generator$.apply(Generator.scala:39)
at io.magentys.donut.Boot$.delayedEndpoint$io$magentys$donut$Boot$1(Boot.scala:85)

amitsha256 · 2017-10-02T08:50:01Z

+
+To run using Docker:
+```
+docker run -v /path/to/your/cucumber-reports:/source -v /path/to/output-report:/output donutreport/donut-docker -n myProjectName [options]


It works for one path(the cucumber path). But it should be able to accept the both cucumber and unit test json paths ex: cucumber:/my/cucumber/path,/my/JUnit/path

…specify multiple source dirs / specflow

temyers · 2017-10-05T06:09:55Z

+
+Donut is packaged as a [Docker container](https://hub.docker.com/r/donutreport/donut-report/)
+
+To run using Docker:


You added a clarifying statement here regarding the version. By default, the current command will choose the LATEST image available.

I've extracted the version into an ENV. This will need to be updated as part of the release, etc.
I've updated the instructions for tagging/deploy to specify the version number.
The version of the container, should match the version of Donut Maven project..

temyers · 2017-10-05T06:12:35Z

+
+Set your Docker Hub credentials
+```
+export VERSION=version_number


These are manual commands at the moment, and need to tally the version.

Next steps will be to automatically build, and will need to get the version from SBT

amitsha256 · 2017-10-06T06:54:53Z

+
+```
+docker run -v /path/to/your/cucumber-reports:/source -v /path/to/your/unit-test-reports:/source_unit -v /path/to/output-report:/output donutreport/donut-report -n myProjectName -s cucumber:/source,/source_unit [options]
+```


These commands are not working. I got this:
Error: Unknown option -s Error: Unknown argument 'cucumber:/source'

temyers requested review from amitsha256 and davebassan September 28, 2017 07:56

Tim Myerscough added 3 commits September 28, 2017 17:34

Add Dockerfile, and docker-compose for building Donut without install…

c5d872d

…ing sbt.

Build Docker container as part of travis build, and push to dockerhub

979a89d

Update README to use Docker Hub version

2b96ced

cache dependencies for travis build Build container from published version. Will use autobuild on Docker Hub Add instructions for manual Docker deployment

temyers force-pushed the dockerfile branch from 46d7704 to 2b96ced Compare September 28, 2017 09:36

don't publish build report for branches. Means Travis builds will wor…

f0488ba

…k for PRs.

temyers commented Sep 28, 2017

View reviewed changes

fix typo

3a9c9cf

temyers requested a review from marcelloromani October 2, 2017 02:00

Updated the readme to specify the version of donut used by Dockerfile…

d8d786a

… and fixed the image name typo

amitsha256 suggested changes Oct 2, 2017

View reviewed changes

Tim Myerscough added 2 commits October 5, 2017 10:16

Extract environment variable for DONUT_VERSION

b72b0d1

Refactor to remove source dir option hard coded. Make it possible to …

f4024a7

…specify multiple source dirs / specflow

temyers commented Oct 5, 2017

View reviewed changes

amitsha256 reviewed Oct 6, 2017

View reviewed changes


		WORKDIR /app

		RUN wget http://repo1.maven.org/maven2/io/magentys/donut/1.0/donut-1.0-one-jar.jar /app/donut.jar


		Donut is packaged as a [Docker container](https://hub.docker.com/r/donutreport/donut-report/)

		To run using Docker:

Uh oh!

Conversation

temyers commented Sep 28, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amitsha256 Oct 6, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

temyers commented Sep 28, 2017 •

edited

Loading

amitsha256 Oct 6, 2017 •

edited

Loading