staggered_orders_trading: use order_quantity/order_price in warning - #3648
Open
blueyed wants to merge 1 commit into
Open
staggered_orders_trading: use order_quantity/order_price in warning#3648blueyed wants to merge 1 commit into
blueyed wants to merge 1 commit into
Conversation
| if not created_order: | ||
| self.logger.warning( | ||
| f"No order created for {order_data} (cost: {quantity * order_data.price}): " | ||
| f"No order created for {order_data} (cost: {order_quantity * order_price}): " |
Member
There was a problem hiding this comment.
order_quantity and order_price are initialized in the above for loop that can yield no iteration, in this case, order_quantity and order_price would be unset. To use them in this log, we need to init them before the loop, to be sure they are always set variables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #3611 (comment)