feat: support entropy input formats - #33
Merged
Merged
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Enhancement, Tests
Description
Add prefixed entropy input support
Support hex entropy during wallet creation
Display mnemonic entropy in wallet show
Cover entropy flows with E2E tests
Diagram Walkthrough
File Walkthrough
wallet-lifecycle.test.ts
Add E2E coverage for entropy formatstests/e2e/wallet-lifecycle.test.ts
--entropy.0bprefix.0xprefix.wallet show --entropyoutputs hex entropy.create.mts
Support formatted entropy for wallet creationsrc/cli/commands/wallet/create.mts
--entropy-bitswith--entropy.0x...or0b...format.show.mts
Add entropy display to wallet showsrc/cli/commands/wallet/show.mts
--entropyoption for wallet details.0x-prefixed hexadecimal.mnemonic.mts
Expose mnemonic entropy conversion helpersrc/crypto/mnemonic.mts
entropyHexOfhelper.