Skip to content

fix: show entropy before mnemonic - #36

Merged
Drincann merged 1 commit into
mainfrom
feat/show-entropy-before-mnemonic
Jun 10, 2026
Merged

fix: show entropy before mnemonic#36
Drincann merged 1 commit into
mainfrom
feat/show-entropy-before-mnemonic

Conversation

@Drincann

@Drincann Drincann commented Jun 10, 2026

Copy link
Copy Markdown
Owner

PR Type

Bug fix, Tests


Description

  • Print entropy before mnemonic

  • Cover combined entropy and mnemonic display


Diagram Walkthrough

flowchart LR
  walletShow["wallet show command"]
  entropy["Entropy output"]
  mnemonic["Mnemonic output"]
  test["E2E ordering test"]
  walletShow -- "prints first" --> entropy
  entropy -- "then prints" --> mnemonic
  test -- "verifies order" --> walletShow
Loading

File Walkthrough

Relevant files
Bug fix
show.mts
Print entropy before mnemonic                                                       

src/cli/commands/wallet/show.mts

  • Reorders wallet display output.
  • Prints Entropy: before Mnemonic: when both flags are used.
  • Applies ordering to wallet and address-reference views.
+2/-2     
Tests
wallet-lifecycle.test.ts
Verify entropy precedes mnemonic                                                 

tests/e2e/wallet-lifecycle.test.ts

  • Updates entropy display E2E test name.
  • Runs wallet show with -e and -m.
  • Asserts entropy appears before mnemonic.
+5/-3     

@github-actions

Copy link
Copy Markdown

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ No major issues detected

@github-actions

Copy link
Copy Markdown

PR Code Suggestions ✨

No code suggestions found for the PR.

@Drincann
Drincann merged commit d86cbf3 into main Jun 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant