Add error page#1237
Open
fgren wants to merge 6 commits into
Open
Conversation
The initial intention was to fix some broken links, but in the end I made some further (primarily semantic) changes: * The Taube quote is now a `<blockquote>`, as opposed to an `<h1>` (more semantically correct, and, in my opinion, more aesthetically pleasing * Make the `<aside>` into a plain `<div>` (it was hard to justify calling it an "aside", since it does not specifically relate to the main content of any page where it is included) * Modify the link hrefs * Remove the study bank and trivia anchors * Make the entire footer wrapped in a `<footer>` rather than a plain `<div>`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧩 Summary
Adds an error page. It's not perfect, but better than the current one. I've chosen to include the navbar and footer, since I think it makes the user feel less lost when encountering the page.
📸 Screenshots / recordings (if applicable)
💬 Other information
Since we now include the navbar and footer, the nollning pages should probably have their own error pages, since they have their own navigation.