Skip to content

fix: set explicit connection watchdog timeout action to AutoDelete#596

Open
MrAlaskan wants to merge 1 commit into
EIPStackGroup:masterfrom
MrAlaskan:fix/class3-watchdog-autodelete-default
Open

fix: set explicit connection watchdog timeout action to AutoDelete#596
MrAlaskan wants to merge 1 commit into
EIPStackGroup:masterfrom
MrAlaskan:fix/class3-watchdog-autodelete-default

Conversation

@MrAlaskan

Copy link
Copy Markdown

Summary

This PR makes explicit messaging connections expose the correct default watchdog timeout action after they are established.

Problem

For explicit messaging connections, the default watchdog timeout action is AutoDelete. However, EstablishClass3Connection() currently deep-copies the parsed connection object, applies ConnectionObjectGeneralConfiguration(), and then adds the connection to the active list without updating the watchdog timeout action for the explicit connection case.

ConnectionObjectGeneralConfiguration() initializes watchdog_timeout_action to Invalid, and there is no later path that corrects the value for class 3 connections. As a result, the connection object can remain externally observable with Attribute 12 set to Invalid even though the actual timeout behavior is implemented through Class3ConnectionTimeoutHandler(), which deletes the connection on timeout.

This creates a mismatch between the exposed connection object state and the runtime timeout behavior for explicit messaging connections.

Changes

  • Set watchdog_timeout_action to kConnectionObjectWatchdogTimeoutActionAutoDelete in EstablishClass3Connection() after the generic connection object configuration step.
  • Keep the existing class 3 timeout handler and connection lifecycle behavior unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant