Route non-Korean Custom Stops to the supported geocoder - #353
Merged
Conversation
Constraint: Preserve VWorld for Korean and blank-country DSV inputs. Rejected: Switch production entirely to Nominatim | Would regress Korean DSV address handling. Confidence: high Scope-risk: moderate Directive: Keep explicit non-KR ISO country codes on the guarded Nominatim-compatible path. Tested: Prisma generate; lint; typecheck; 2135 tests passed with 108 skipped; delivery-api build; git diff check. Not-tested: Production Custom Stop smoke pending deployment.
This was referenced Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #348
Change control: EVNSolution/clever-change-control#270
Why
Production smoke proved that authoritative Custom Stop geocoding still failed for Shopify Canada because the runtime is in VWorld mode and VWorld deliberately ignores non-KR queries.
Change
Verification
Production boundary
No runtime or AWS change is included. Keep #348 open until the Navi Test Custom Stop smoke passes after an explicitly approved production deploy.