Skip to content

Require dispatcher-confirmed Custom Stop navigation pins - #218

Merged
OziinG merged 1 commit into
mainfrom
cc-267-kfood-custom-stop-address
Aug 26, 2026
Merged

Require dispatcher-confirmed Custom Stop navigation pins#218
OziinG merged 1 commit into
mainfrom
cc-267-kfood-custom-stop-address

Conversation

@OziinG

@OziinG OziinG commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Why

Prevent blank or stale Custom Stop coordinates from becoming route destinations, without sending customer delivery addresses to an unapproved public autocomplete service.

Changes

  • require a dispatcher-selected map pin before Custom Stop save
  • clear the pin whenever address fields change, while preserving it for unrelated edits
  • reject missing, invalid, or (0,0) coordinates and invalid country codes
  • exclude legacy (0,0) locations from markers, fit bounds, and snapped route geometry
  • keep Settings single-result geocoding behavior with safe blank-coordinate parsing
  • add behavior regression coverage

Verification

  • npm test: 597/597
  • typecheck
  • build
  • ESLint
  • public URL guard
  • Shopify UI validator
  • git diff --check

Tracking

Constraint: Customer delivery addresses must not be sent to an unapproved public autocomplete provider.
Rejected: Public Nominatim autocomplete | privacy and service-policy risks make it unsuitable for delivery addresses.
Confidence: high
Scope-risk: moderate
Directive: Describe these coordinates as dispatcher-selected navigation pins, not verified addresses.
Tested: npm test 597/597; typecheck; build; ESLint; public URL guard; Shopify validator; git diff --check
Not-tested: Production browser interaction and deployed K-food route mutation
@OziinG OziinG linked an issue Aug 26, 2026 that may be closed by this pull request
6 tasks
@OziinG
OziinG merged commit 8c4d12f into main Aug 26, 2026
2 checks passed
@OziinG
OziinG deleted the cc-267-kfood-custom-stop-address branch August 26, 2026 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Require verified address selection for K-food custom stops

1 participant