Skip to content

Add Phase 2 NPCs, aging/wisdom bonuses, simstagram helpers, organic encounter summaries, and tests - #17

Merged
Earnest-Williams merged 5 commits into
mainfrom
codex/fix-review-comments-in-pr-#15-lz323d
Jun 7, 2026
Merged

Add Phase 2 NPCs, aging/wisdom bonuses, simstagram helpers, organic encounter summaries, and tests#17
Earnest-Williams merged 5 commits into
mainfrom
codex/fix-review-comments-in-pr-#15-lz323d

Conversation

@Earnest-Williams

Copy link
Copy Markdown
Owner

Motivation

  • Extend the world with a second phase of NPCs and wire them into encounters, schedules, dates, and reputation while improving UX for organic encounters and Simstagram posting rules.
  • Introduce life-progression mechanics that reward older characters with small "wisdom" bonuses to eligible stat gains and add birthday progression when time advances.
  • Factor out small UI and simulation helpers to centralize logic for organic encounter reward summaries and Simstagram eligibility/stat multipliers.

Description

  • Added a new Phase 2 NPC set and romance arcs and integrated them into NPCS, DATE_PREFERENCES, NPC_SCHEDULE, and REPUTATION_CIRCLES by updating src/data/npcs.js, src/data/dates.js, src/data/townTexture.js, and src/sim/reputation.js.
  • Implemented an aging/wisdom system with applyWisdomBonus and birthday progression in simulateTicks, and applied the bonus across stat gains in action.js (routines, actions, cooking, and course completion).
  • Extracted organic encounter reward formatting to src/components/organicEncounterRewards.js and updated OrganicEncounterUI.jsx to show reward summaries inline with choices.
  • Added Simstagram helper functions in src/sim/simstagram.js and integrated them into SimstagramApp.jsx and the socialMedia reducer to unify energy checks and stat multiplier math.
  • Small refactors and cleanup across components to remove unused imports and standardize logic (e.g. TimeControls speed constants, selector adjustment in selectors.js, and minor fixes in dashboard components).
  • Added comprehensive unit tests validating aging/wisdom behavior, Phase 2 NPC integration, Simstagram consistency, organic encounter summary formatting, relationship memory constraints, romance arc shape, and UI privacy checks under test/*.test.js.

Testing

  • Ran the test suite via the project test runner (npm test / node:test) which executed the new unit tests in test/agingWisdom.test.js, test/phase2NpcIntegration.test.js, test/simstagramConsistency.test.js, test/organicEncounterUI.test.js, test/relationshipMemory.test.js, test/romanceArc.test.js, and test/compatibilityPrivacy.test.js.
  • All new and existing automated tests passed successfully without regressions.

Codex Task

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces Phase 2 NPCs with complete romance arcs, schedules, and preferences, alongside a new birthday progression system and a 'wisdom bonus' that boosts stat gains for characters over age 30. It also refactors Simstagram logic into a dedicated utility module and adds extensive test coverage. The review feedback focuses on enhancing robustness by adding defensive checks to several new functions to prevent potential runtime crashes when dealing with null or undefined inputs.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/components/organicEncounterRewards.js
Comment thread src/sim/simstagram.js
Comment thread src/state/reducers/action.js
Comment thread src/state/reducers/time.js
Earnest-Williams and others added 4 commits June 7, 2026 01:20
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@Earnest-Williams
Earnest-Williams merged commit da32c6e into main Jun 7, 2026
2 checks passed
@Earnest-Williams
Earnest-Williams deleted the codex/fix-review-comments-in-pr-#15-lz323d branch June 7, 2026 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant