Add Phase 2 NPCs, aging/wisdom bonuses, simstagram helpers, organic encounter summaries, and tests - #17
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces Phase 2 NPCs with complete romance arcs, schedules, and preferences, alongside a new birthday progression system and a 'wisdom bonus' that boosts stat gains for characters over age 30. It also refactors Simstagram logic into a dedicated utility module and adds extensive test coverage. The review feedback focuses on enhancing robustness by adding defensive checks to several new functions to prevent potential runtime crashes when dealing with null or undefined inputs.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Motivation
Description
NPCS,DATE_PREFERENCES,NPC_SCHEDULE, andREPUTATION_CIRCLESby updatingsrc/data/npcs.js,src/data/dates.js,src/data/townTexture.js, andsrc/sim/reputation.js.applyWisdomBonusand birthday progression insimulateTicks, and applied the bonus across stat gains inaction.js(routines, actions, cooking, and course completion).src/components/organicEncounterRewards.jsand updatedOrganicEncounterUI.jsxto show reward summaries inline with choices.src/sim/simstagram.jsand integrated them intoSimstagramApp.jsxand thesocialMediareducer to unify energy checks and stat multiplier math.TimeControlsspeed constants, selector adjustment inselectors.js, and minor fixes in dashboard components).test/*.test.js.Testing
npm test/node:test) which executed the new unit tests intest/agingWisdom.test.js,test/phase2NpcIntegration.test.js,test/simstagramConsistency.test.js,test/organicEncounterUI.test.js,test/relationshipMemory.test.js,test/romanceArc.test.js, andtest/compatibilityPrivacy.test.js.Codex Task