Skip to content

Phase 3: Reputation & Social Systems - #22

Merged
Earnest-Williams merged 2 commits into
mainfrom
vibe/phase1-relationship-core-566a93
Jun 7, 2026
Merged

Phase 3: Reputation & Social Systems#22
Earnest-Williams merged 2 commits into
mainfrom
vibe/phase1-relationship-core-566a93

Conversation

@Earnest-Williams

Copy link
Copy Markdown
Owner

Changes

  • Enabled reputationSpillover feature flag
  • Enabled compatibilityRevealUx feature flag
  • Added comprehensive reputation selectors:
    • selectReputation(state, circle)
    • selectNpcReputation(state, npcId)
    • selectAllReputation(state)
    • selectReputationHint(state, circle)
    • isReputationSpilloverEnabled(state)
    • selectReputationWarnings(state)

Features Now Active

✅ Reputation Spillover: Reputation in social circles affects relationship dynamics ✅ Compatibility Reveal UX: Narrative compatibility hints (not raw numbers)

Reputation System

  • 6 reputation circles: coworkers, friends, nightlife, creative, academic, exes
  • Reputation affects: gossip risk, repair difficulty, public date visibility
  • Reputation ranges: -100 to 100
  • Selectors provide easy access to reputation data for UI integration

Verification

  • All 69 tests pass
  • Action audit: 49 dispatched, 62 handled cases
  • Content validation: All checks pass, 0 errors
  • No regressions introduced

What This Enables

  • Reputation system is now active and affects gameplay
  • Compatibility hints can be displayed in UI (selectors ready)
  • Social circles track player standing with different groups
  • Reputation warnings can be shown to players

Next Steps

  • Phase 4: Enable remaining feature flags (marketRiskControls, adultToneTags)
  • Phase 4: Add UI for reputation display
  • Phase 4: Add UI for compatibility hints

## Changes
- Enabled reputationSpillover feature flag
- Enabled compatibilityRevealUx feature flag
- Added comprehensive reputation selectors:
  - selectReputation(state, circle)
  - selectNpcReputation(state, npcId)
  - selectAllReputation(state)
  - selectReputationHint(state, circle)
  - isReputationSpilloverEnabled(state)
  - selectReputationWarnings(state)

## Features Now Active
✅ Reputation Spillover: Reputation in social circles affects relationship dynamics
✅ Compatibility Reveal UX: Narrative compatibility hints (not raw numbers)

## Reputation System
- 6 reputation circles: coworkers, friends, nightlife, creative, academic, exes
- Reputation affects: gossip risk, repair difficulty, public date visibility
- Reputation ranges: -100 to 100
- Selectors provide easy access to reputation data for UI integration

## Verification
- All 69 tests pass
- Action audit: 49 dispatched, 62 handled cases
- Content validation: All checks pass, 0 errors
- No regressions introduced

## What This Enables
- Reputation system is now active and affects gameplay
- Compatibility hints can be displayed in UI (selectors ready)
- Social circles track player standing with different groups
- Reputation warnings can be shown to players

## Next Steps
- Phase 4: Enable remaining feature flags (marketRiskControls, adultToneTags)
- Phase 4: Add UI for reputation display
- Phase 4: Add UI for compatibility hints

Co-authored-by: Earnest-Williams <Earnest-Williams@users.noreply.github.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables the compatibilityRevealUx and reputationSpillover features in the initial state of the root reducer. It also introduces several selectors to query reputation scores, hints, and warnings. The review feedback points out an unused import (REPUTATION_CIRCLES) in the selectors file that should be removed to keep the codebase clean.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/state/selectors.js Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@Earnest-Williams
Earnest-Williams merged commit b745135 into main Jun 7, 2026
1 of 2 checks passed
@Earnest-Williams
Earnest-Williams deleted the vibe/phase1-relationship-core-566a93 branch June 7, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants