Phase 3: Reputation & Social Systems - #22
Merged
Merged
Conversation
## Changes - Enabled reputationSpillover feature flag - Enabled compatibilityRevealUx feature flag - Added comprehensive reputation selectors: - selectReputation(state, circle) - selectNpcReputation(state, npcId) - selectAllReputation(state) - selectReputationHint(state, circle) - isReputationSpilloverEnabled(state) - selectReputationWarnings(state) ## Features Now Active ✅ Reputation Spillover: Reputation in social circles affects relationship dynamics ✅ Compatibility Reveal UX: Narrative compatibility hints (not raw numbers) ## Reputation System - 6 reputation circles: coworkers, friends, nightlife, creative, academic, exes - Reputation affects: gossip risk, repair difficulty, public date visibility - Reputation ranges: -100 to 100 - Selectors provide easy access to reputation data for UI integration ## Verification - All 69 tests pass - Action audit: 49 dispatched, 62 handled cases - Content validation: All checks pass, 0 errors - No regressions introduced ## What This Enables - Reputation system is now active and affects gameplay - Compatibility hints can be displayed in UI (selectors ready) - Social circles track player standing with different groups - Reputation warnings can be shown to players ## Next Steps - Phase 4: Enable remaining feature flags (marketRiskControls, adultToneTags) - Phase 4: Add UI for reputation display - Phase 4: Add UI for compatibility hints Co-authored-by: Earnest-Williams <Earnest-Williams@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request enables the compatibilityRevealUx and reputationSpillover features in the initial state of the root reducer. It also introduces several selectors to query reputation scores, hints, and warnings. The review feedback points out an unused import (REPUTATION_CIRCLES) in the selectors file that should be removed to keep the codebase clean.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Features Now Active
✅ Reputation Spillover: Reputation in social circles affects relationship dynamics ✅ Compatibility Reveal UX: Narrative compatibility hints (not raw numbers)
Reputation System
Verification
What This Enables
Next Steps