DRAFT. Expand test for geoscience libraries#59
Draft
eshntmshra wants to merge 1 commit into
Draft
Conversation
sarahw-earthscope
left a comment
Collaborator
There was a problem hiding this comment.
This looks good to me!
We need to ensure the developer checklist includes instructions to update these test files with any new packages they add.
| import dascore | ||
|
|
||
| assert hasattr(dascore, "__version__") | ||
| import dascore as dc |
Collaborator
There was a problem hiding this comment.
Not a comment on the test package... but we need to consider why we are including dascore in the image build at all. We don't currently provide das data through our archive, and I'm not sure we want to encourage researchers to upload das data (big files) to geolab for the sole purpose of processing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deepens the tests for four geophysics libraries from import/version-only checks to a real operation that exercises the package's core functionality:
gmt-gshhg/gmt-dcw, which nothing tested before)All tests use bundled or synthetic data that require no network, no credentials, no external files.
Ran
pytest test_packages.py -vand re-ran thetest_notebook.ipynbnotebook cells in GeoLab and all tests passed.