Skip to content

DRAFT. Expand test for geoscience libraries#59

Draft
eshntmshra wants to merge 1 commit into
EarthScope:mainfrom
eshntmshra:tests/update-image-test-suite
Draft

DRAFT. Expand test for geoscience libraries#59
eshntmshra wants to merge 1 commit into
EarthScope:mainfrom
eshntmshra:tests/update-image-test-suite

Conversation

@eshntmshra

Copy link
Copy Markdown
Contributor

Deepens the tests for four geophysics libraries from import/version-only checks to a real operation that exercises the package's core functionality:

  • dascore — load an example DAS patch and decimate it
  • obspy — read the bundled example waveform and apply a bandpass filter
  • obsplus — index a directory with a WaveBank and confirm the channels round-trip
  • pygmt — render a coastline (also exercises the apt-installed GMT map data, gmt-gshhg / gmt-dcw, which nothing tested before)

All tests use bundled or synthetic data that require no network, no credentials, no external files.

Ran pytest test_packages.py -v and re-ran the test_notebook.ipynb notebook cells in GeoLab and all tests passed.

@eshntmshra eshntmshra closed this Jul 21, 2026
@eshntmshra
eshntmshra deleted the tests/update-image-test-suite branch July 21, 2026 17:00
@eshntmshra
eshntmshra restored the tests/update-image-test-suite branch July 21, 2026 17:01
@eshntmshra eshntmshra reopened this Jul 21, 2026

@sarahw-earthscope sarahw-earthscope left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!
We need to ensure the developer checklist includes instructions to update these test files with any new packages they add.

import dascore

assert hasattr(dascore, "__version__")
import dascore as dc

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a comment on the test package... but we need to consider why we are including dascore in the image build at all. We don't currently provide das data through our archive, and I'm not sure we want to encourage researchers to upload das data (big files) to geolab for the sole purpose of processing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants