Skip to content

Send unresolved action outcomes to proof #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EauDoon merged 1 commit into from
Aug 29, 2026
Merged

Send unresolved action outcomes to proof #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions bin/aas.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ export const DEFAULT_PATHS = Object.freeze({
lock: join(root, "stack-lock.json"),
});

const DISPUTE_OUTCOMES = new Set(["compensated", "disputed"]);
const STAGE_NAMES = ["decide", "act", "prove"];
const DEMO_FLAG_OPTIONS = new Set(["--dispute", "--json"]);
const DEMO_VALUE_OPTIONS = new Set(["--response", "--fault"]);
Expand Down Expand Up @@ -442,7 +441,7 @@ export async function runDemo(args = [], options = {}) {
bundle_verification: act.raw?.bundle_verification ?? null,
};
report.flow = "decide -> act";
const shouldProve = forceDispute || DISPUTE_OUTCOMES.has(outcome);
const shouldProve = forceDispute || outcome !== "settled";
if (!shouldProve) {
stages.prove = stageRecord("skipped", { reason: "no_dispute" });
report.stages.prove = stages.prove;
Expand All @@ -455,7 +454,7 @@ export async function runDemo(args = [], options = {}) {
report.stages.prove = {
status: stages.prove.status,
scenario,
triggered_by: forceDispute && !DISPUTE_OUTCOMES.has(outcome) ? "--dispute" : `act_outcome=${outcome}`,
triggered_by: forceDispute && outcome === "settled" ? "--dispute" : `act_outcome=${outcome}`,
ok: prove.ok,
result_keys: prove.raw?.result && typeof prove.raw.result === "object" ? Object.keys(prove.raw.result) : [],
};
Expand Down
16 changes: 16 additions & 0 deletions test/stack.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,22 @@ test("dispute bundle runs prove and records its trigger", async () => {
assert.deepEqual(readdirSync(join(result.bundleDir, "stages")).sort(), ["act.json", "decide.json", "prove.json"]);
});

test("an unresolved act outcome is sent to proof", async () => {
const outputRoot = tempRoot();
let proveCalls = 0;
const result = await runDemo(["--response", "pass"], stubOptions(outputRoot, {
runId: "unresolved-run",
runActFn: async () => ({ ok: true, raw: { outcome: null, state: "UNKNOWN", fault: "lost-response-before-commit" }, status: 0 }),
runProveFn: async () => {
proveCalls += 1;
return { ok: true, raw: { ok: true, result: { evidence: true } }, status: 0 };
},
}));
assert.equal(proveCalls, 1);
assert.equal(result.manifest.stages.prove.status, "passed");
assert.equal(result.report.stages.prove.triggered_by, "act_outcome=null");
});

test("child-process errors are visible as safe stage errors and downstream skips", async () => {
const outputRoot = tempRoot();
const result = await runDemo(["--response", "pass"], stubOptions(outputRoot, {
Expand Down
Loading