fix: correlate sidecar failures with request ids - #10
Merged
Conversation
Unexpected HTTP exceptions were swallowed as REQUEST_INVALID with no operator diagnostic. Failures now include a request_id (and action_id when the route named one), log the real cause to stderr, and return INTERNAL_ERROR to the client.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
Devin Review found 1 potential issue.
1 flag not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
| if (request.method !== allowedMethod) { | ||
| methodNotAllowed(response, [allowedMethod]); | ||
| methodNotAllowed(response, [allowedMethod], requestId); | ||
| return; |
There was a problem hiding this comment.
🟡 Wrong-method failures omit action identifiers
When an action endpoint receives the wrong HTTP method, methodNotAllowed omits its action identifier. Correlation then loses the affected action.
Prompt for agents
Update src/http-server.js so methodNotAllowed can include an action_id for matched action routes while preserving the current response shape for non-action routes. Pass the validated actionId from the action-route method check, and add a regression test for a wrong method on /v0/actions/{action_id} or one of its operations.
Was this helpful? React with 👍 or 👎 to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
HTTP sidecar failures now carry a
request_id, and action routes include theaction_idthey were asked about. Unexpected exceptions are no longer mapped toREQUEST_INVALID; the sidecar logs the real cause to stderr and returnsINTERNAL_ERRORwithout leaking that cause to the client.Why
The reference server swallowed non-
RailErrorexceptions as a generic client error with nothing an operator could correlate. Boundary failures (malformed JSON, missing actions, method not allowed) also had no request identifier.How tested
node ./scripts/check.jsnode --test