Preserve state when audit appends fail - #15
Merged
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
Devin Review found 1 potential issue.
3 flags not posted on this PR by your GitHub settings — view them in Devin Review. (Configure)
| details_digest: digest(details ?? {}), | ||
| }); | ||
| }; | ||
| this.eventStore.append(record.action_id, "STATE_TRANSITION", "rail", eventPayload); |
There was a problem hiding this comment.
🔴 Failed audits retain partial mutations
When append fails, transition preserves the lifecycle state but retains earlier caller mutations. Execution consumes an unused permit, while remediation consumes an unstarted attempt.
Prompt for agents
Make each lifecycle operation failure-atomic for both its transition event and all in-memory record fields changed before that event. Audit callers of transition in src/rail.js, especially execute and remediate: permit_uses and remedy_attempts are incremented before the transition append, and several flows assign reservation, permit, execution, remedy-result, or evidence data before appending. Stage those values until the relevant append succeeds, or restore the complete prior record when append throws. Preserve the required ordering that permit consumption is durably recorded before invoking the connector, and add failure-injection tests at every transition boundary, including transitions after connector side effects.
Was this helpful? React with 👍 or 👎 to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
npm run check(135 tests).