Bind connector result snapshots - #6
Merged
Merged
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| const status = assertConnectorResult( | ||
| await this.connector.remedyStatus(record.remedy_idempotency_key), | ||
| record.remedy_idempotency_key, | ||
| REMEDY_STATUSES, |
There was a problem hiding this comment.
🟡 Confirmed no-change remedies become unresolved
When reconciliation returns no_change, REMEDY_STATUSES accepts it but classifies it as unresolved. The action enters manual review instead of confirmed remedy failure.
Prompt for agents
In src/rail.js, reconcileRemedy accepts no_change through REMEDY_STATUSES, but its branching treats only no_effect and failed as confirmed remedy failures. Align no_change reconciliation with direct remediation and the state-machine rule that a confirmed absent remedy effect transitions to REMEDY_FAILED. Add a test that reaches REMEDY_UNKNOWN, returns a bound no_change result from remedyStatus, and verifies the failed/disputed close path.
Was this helpful? React with 👍 or 👎 to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- bind exact keys and statuses on all four connector-result paths\n- store frozen, null-prototype owned snapshots at the trust boundary\n\n## Tests\n- repository check across 53 files; full 102/102\n- mutation, proxy, accessor, and inherited-field probes