Conversation
refs #35
This was referenced Apr 24, 2026
daniel-jettka
approved these changes
Apr 27, 2026
Contributor
daniel-jettka
left a comment
daniel-jettka
left a comment
There was a problem hiding this comment.
In conjunction with just approved Edirom/Edirom-Online-Backend#168 this looks very good to me :-)
Also see screenshot at Edirom/Edirom-Online-Backend#168 (review)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description, Context and related Issue
The search was not working. Since the Klarinettenquintett has a working search, its collection.xconf was consulted and adapted for
MEI.htmlwas added newly.Note:
This did not seem to solve the whole problem. Since Klarinettenquintett has its annotation text in
annotelements in the source file (source-4-MEI.xml), the EditionExampe (and most other Edirom Editions) capture their annotations in the work file andworkelement. See Edirom/Edirom-Online-Backend#167 so the whole picture only works with this PR and the PR in the backend.Refs #35
How Has This Been Tested?
Types of changes