Add more information about formatter to docs#1124
Conversation
There was a problem hiding this comment.
Code Review Summary
This PR adds documentation for a new emmylua_formatter crate. The changes are clean and well-structured. Here are my observations:
✅ Positive Aspects
- Consistent formatting with existing documentation style
- Proper table alignment in CONTRIBUTING.md
- Clear, concise descriptions
- Good placement of new content in logical order
🔍 Issues Found
-
Missing crate description in README.md
- The
emmylua_formattercrate is listed in the install section but not in the crate overview table at the top of README.md - Suggestion: Add a row for
emmylua_formatterin the crate table for consistency
- The
-
Inconsistent command example
- The formatter example uses
luafmtwhile the crate is namedemmylua_formatter - Suggestion: Either clarify that
luafmtis an alias, or useemmylua_formatterin the example for consistency
- The formatter example uses
-
Missing formatter options documentation
- Other tools show available flags/options, but the formatter only shows one example
- Suggestion: Add a table of available options (e.g.,
--write,--check, config file support)
📝 Minor Suggestions
- Consider adding a link to the formatter's own documentation or configuration guide
- The formatter description in CONTRIBUTING.md could be more descriptive about its features (e.g., "Configurable Lua code formatter with customizable style rules")
🏁 Overall Assessment
Approved with minor suggestions. The changes are functionally correct and maintain the project's documentation standards. The issues noted are non-blocking improvements.
There was a problem hiding this comment.
Code Review
This pull request updates the documentation in README.md and CONTRIBUTING.md to introduce the new emmylua_formatter crate, including its installation via Cargo and usage instructions using the luafmt command. The review feedback suggests improving visual clarity in the crates table by using a distinct emoji for the formatter, and clarifying that installing emmylua_formatter provides the luafmt binary.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| ```bash | ||
| # Via Cargo | ||
| cargo install emmylua_ls # Language server | ||
| cargo install emmylua_formatter # Code formatter |
There was a problem hiding this comment.
Since installing the emmylua_formatter crate actually provides the luafmt binary, it would be helpful to explicitly mention luafmt in the comment to avoid confusion for users looking for an emmylua_formatter executable.
| cargo install emmylua_formatter # Code formatter | |
| cargo install emmylua_formatter # Code formatter (luafmt) |
There was a problem hiding this comment.
I'm not sure about this, since nothing else follows this pattern, but nothing else needs to. Will wait for human feedback on this one.
For being a seemingly-major part of the toolchain,
emmylua_formatter/luafmtwasn't explicitly named inREADME.mdorCONTRIBUTING.md.