Use PR instead of direct push to main - #1516
Open
dalonsoa wants to merge 4 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1516 +/- ##
=======================================
Coverage 90.47% 90.47%
=======================================
Files 61 61
Lines 8899 8899
Branches 8899 8899
=======================================
Hits 8051 8051
Misses 523 523
Partials 325 325 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes the CI benchmark-baseline update mechanism so that baseline updates on main are proposed via an auto-generated pull request (rather than a direct push), aligning with main-branch push restrictions.
Changes:
- Replace the “commit & push updated baseline” step with an automated PR created by
peter-evans/create-pull-request. - Add workflow documentation explaining the fixed PR branch strategy, recursion behaviour, and
[skip ci]usage.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As there are restriction issues when pushing things to main, now the baseline is added to main via a PR, that needs to be approved and merged.
Mind that as the branch to do the PR from is fixed, if we have multiple PR open, the last one to complete its benchmark run will be the one whose baseline benchmark is considered.
Fixes # (issue)
Type of change
Key checklist
$ cargo test$ cargo docpresent in the previous release
Further checks