Skip to content

chore: pay down technical debt introduced through recent changes - #133

Open
richards-ensono wants to merge 50 commits into
mainfrom
chore/cleanup-code-smells
Open

chore: pay down technical debt introduced through recent changes#133
richards-ensono wants to merge 50 commits into
mainfrom
chore/cleanup-code-smells

Conversation

@richards-ensono

@richards-ensono richards-ensono commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • remediate the scoped SonarCloud code-smell findings without changing the quality gate or scanner configuration
  • preserve and independently review Git SSH and workflow-policy trust boundaries
  • fix GlobalKnownHostsFile command precedence and quoted/escaped/multiple paths in direct and included SSH configuration

Validation

  • go test ./...
  • go test -race ./internal/config ./runner ./scheduler
  • go vet ./scripts/check-workflow-policy
  • bash scripts/check-workflow-security.sh
  • bash scripts/check-immutable-ci-dependencies.sh
  • bash scripts/check-codeowners.sh
  • schema generation and git diff --exit-code -- schemas

@richards-ensono
richards-ensono requested a review from a team July 27, 2026 11:39
@richards-ensono
richards-ensono enabled auto-merge (squash) July 27, 2026 11:39
@richards-ensono richards-ensono changed the title Restore SonarCloud quality gate chore: pay down technical debt introduced through recent changes Jul 27, 2026
@richards-ensono richards-ensono self-assigned this Jul 28, 2026
@richards-ensono richards-ensono added go Pull requests that update go code github_actions Pull requests that update GitHub Actions code security Issues and pull requests that materially affect security labels Jul 28, 2026
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code go Pull requests that update go code security Issues and pull requests that materially affect security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant