Skip to content

fix: allow for ignoring of unparseable directives in SSH config files - #68

Open
dnitsch wants to merge 8 commits into
mainfrom
fix/error-message
Open

fix: allow for ignoring of unparseable directives in SSH config files#68
dnitsch wants to merge 8 commits into
mainfrom
fix/error-message

Conversation

@dnitsch

@dnitsch dnitsch commented Oct 17, 2025

Copy link
Copy Markdown
Contributor

addresses #64

add better error message for git config

@sonarqubecloud

Copy link
Copy Markdown

@dnitsch dnitsch changed the title fix: add better error message for git config fix: allow for ignoring of unparseable directives in SSH config files Nov 3, 2025

@RichardSlater RichardSlater left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richards-ensono

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Copilot AI commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Merge conflicts resolved in commit fix: resolve merge conflicts from main into fix/error-message branch.

The conflicts were in two files:

  • internal/config/loader_git.go: Updated processSSHConfig to match main's signature (returns error) and incorporated the UserKnownHostsFiles, SystemKnownHostsFiles, and StrictHostKeyChecking processing blocks from main.
  • internal/config/loader_git_test.go: Combined both sets of changes (our //-commented directive test lines and main's StrictHostKeyChecking no additions), and fixed the NewGitSource call to use schema.ImportEntry{Src: ...} to match the updated function signature from main.

Build and all tests pass.

@richards-ensono richards-ensono left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants