fix(core): normalize rubric grader name to rubrics#1196
Merged
Conversation
Deploying agentv with
|
| Latest commit: |
9c88a23
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f78e3dd3.agentv.pages.dev |
| Branch Preview URL: | https://fix-rubric-name-consistency.agentv.pages.dev |
The criteria: shorthand path (buildLlmGraderFromCriteria) returned name: 'rubric' while the explicit type: rubrics assertion path (generateAssertionName) returned 'rubrics'. Both code paths were written in the same PR — the singular form was an oversight. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
christso
force-pushed
the
fix/rubric-name-consistency
branch
from
fa4577d to
9c88a23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
criteria:shorthand path (buildLlmGraderFromCriteria) hardcodedname: 'rubric'while the explicittype: rubricsassertion path (generateAssertionName) returned'rubrics'. Both were written in the same PR — the singular form was an oversight.Also fixes an import ordering lint issue in
scripts/check-grader-scores.ts(from #1191) that was blocked by the pre-push hook.Changes
packages/core/src/evaluation/loaders/grader-parser.ts:name: 'rubric'→name: 'rubrics'inbuildLlmGraderFromCriteriaexamples/features/rubric/evals/dataset.eval.baseline.jsonl: updated"name":"rubric"→"name":"rubrics"(the only baseline file affected)scripts/check-grader-scores.ts: fix Biome import orderImpact
Users relying on
scores[].name == "rubric"when using thecriteria:shorthand need to update to"rubrics". The explicittype: rubricsassertion path was already producing"rubrics", so those users are unaffected.