fix(model): distinct content hashes for undefined; record two LOW limits - #37
Merged
Conversation
oxaudit float pool (L2, L3, L5, L11; DECISIONS section 63).
L2: stableSerialize's '?? null' fallback collapsed an explicit undefined onto null serialization, so {a: undefined} and {a: null} hashed identically. Now emits the bare token 'undefined' - the string only feeds createHash, so it must be injective, not valid JSON. No live constructor reaches the branch.
L11: classifyContentShape reads the basename's extension instead of the whole path's last dot segment. Measured: every dotted-directory leak already fell through to probes byte-identically, so no classification changes; the new pins make any future reachable leak fail loudly.
L3 recorded: 'h -> c' stays for declaration parity with the .h filename route; characterized in declared-language.test.ts.
L5 recorded: git path matching stays case-sensitive (platform-dependent scores would trade determinism for a lower-score edge case); documented at normalizeGitPath and topology-scorer.
Tests: 737 -> 743. typecheck/lint/test clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
oxaudit float pool (L2, L3, L5, L11; DECISIONS section 63).
L2: stableSerialize's '?? null' fallback collapsed an explicit undefined onto null serialization, so {a: undefined} and {a: null} hashed identically. Now emits the bare token 'undefined' - the string only feeds createHash, so it must be injective, not valid JSON. No live constructor reaches the branch.
L11: classifyContentShape reads the basename's extension instead of the whole path's last dot segment. Measured: every dotted-directory leak already fell through to probes byte-identically, so no classification changes; the new pins make any future reachable leak fail loudly.
L3 recorded: 'h -> c' stays for declaration parity with the .h filename route; characterized in declared-language.test.ts.
L5 recorded: git path matching stays case-sensitive (platform-dependent scores would trade determinism for a lower-score edge case); documented at normalizeGitPath and topology-scorer.
Tests: 737 -> 743. typecheck/lint/test clean.