Remove -b flag for C# parser#846
Remove -b flag for C# parser#846LakatosMark1 wants to merge 1 commit intoEricsson:feature/csharp_pluginfrom
Conversation
…roj and populate build graph
mcserep
added
Plugin: C#
| void addSource(const std::string& filepath_, bool error_); | ||
| const std::vector<std::string>& path_ //, | ||
| ); //const std::string& buildPath_ | ||
| //void addSource(const std::string& filepath_, bool error_); |
There was a problem hiding this comment.
Remove commented out code from codebase.
| bool CsharpParser::parseProjectBuildPath( | ||
| const std::vector<std::string>& paths_, | ||
| const std::string& buildPath_) | ||
| const std::vector<std::string>& paths_ //, |
There was a problem hiding this comment.
Remove commented out comma.
| Console.WriteLine(p); | ||
| allFiles.AddRange(GetSourceFilesFromDir(p, ".cs")); | ||
| // We find all .csproj files | ||
| var csprojFiles = Directory.GetFiles(p, "*.csproj", SearchOption.AllDirectories); |
There was a problem hiding this comment.
Project file processing should be solved with the proper tooling, the Microsoft.CodeAnalysis.CSharp.Workspaces NuGet package exists for that.
We can reuse this from #847.
| assemblies_base = GetSourceFilesFromDir(_buildDirBase, ".dll"); | ||
|
|
||
|
|
||
| IEnumerable<string> assemblies_base = GetSourceFilesFromDir(_buildDirBase, ".dll"); //loading basic dlls |
There was a problem hiding this comment.
Do we really need to collect the DLL paths here?
There was a problem hiding this comment.
It is necessary because without them, the parser cannot resolve basic .NET framework types. This logic was already in the previous version, , I just updated it because of the changes to the command-line parameters.
| // Find the DLL name and append a | to the filename. | ||
| string target = fileToTargetDll.ContainsKey(tree.FilePath) ? fileToTargetDll[tree.FilePath] : "Unknown.dll"; | ||
| WriteLine((visitor.FullyParsed ? "+" : "-") + tree.FilePath + "|" + target); |
There was a problem hiding this comment.
Why do we print the results in such an odd format?
There was a problem hiding this comment.
The + equals fully parsed, - partially parsed and the | separates the dll name and the filepath. The csharpparser.cpp separates them by this format. Should i change it to something else?
2 participants
Refactor C# parser to extract target DLLs from .csproj and populate build graph
Resolves #820