Fix labelled data counts not covering all selected train IDs - #751
Open
philsmt wants to merge 1 commit into
Open
Fix labelled data counts not covering all selected train IDs#751philsmt wants to merge 1 commit into
philsmt wants to merge 1 commit into
Conversation
philsmt
force-pushed
the
fix/incomplete-labelled-counts
branch
from
July 2, 2026 07:14
a42ce8a to
86303ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building tests for
exdf-tools, I noticed a difference in behaviour between labelled and unlabelledKeyData.data_counts(). Whereas the latter always covers the selected train IDs, the former only contains only those described by data chunks for this key.This situation can arise if a source is missing entirely in one or more sequences as opposed to being present with no data counts. In practice, this can happen e.g. when:
exdf-reduce(what triggered this observation)While this is somewhat recoverable given the returned series is labelled, I would argue our APIs generally cover all selected train IDs and hence I would fix this for consistency.