fix(cli): surface memory backend start failures on stderr - #303
Open
icn5381 wants to merge 1 commit into
Open
Conversation
The four backend.start() call sites (agent REPL x2, gateway, TUI) caught the failure with logger.exception only. Under the TUI loguru is redirected to a file, so an invalid memory identity (rejected by EverosBackend in start()) silently turned long-term memory off with nothing on screen. Add a warn_memory_start_failed helper that prints to stderr (mirroring the embedding-unavailable warning in everos/backend.py) and call it from every start() call site, so a degraded-memory condition is visible in every entry point instead of only the agent REPL and gateway. Co-authored-by: Claude (claude-opus-5) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The four memory-backend start() call sites (agent REPL x2, gateway, TUI) caught failures with logger.exception only. Under the TUI loguru is redirected to a file, so an invalid memory identity (rejected by EverosBackend._validate_identity in start()) silently turned long-term memory off with nothing on screen. The agent REPL and gateway already surface the traceback via stderr; only the TUI was silent.
Add a warn_memory_start_failed helper that prints to stderr (mirroring the embedding-unavailable warning in everos/backend.py) and call it from every start() call site, so the degraded-memory condition is visible in every entry point.
Type
Verification
uv run pytest tests/test_memory_warn.py -v-> 1 passeduv run ruff format(5 files unchanged),uv run ruff check(all passed)Risk
Related Issues
Fixes #271