fix(turn): clear active slot on cancel to avoid phantom -32003 - #304
Open
icn5381 wants to merge 1 commit into
Open
fix(turn): clear active slot on cancel to avoid phantom -32003#304icn5381 wants to merge 1 commit into
icn5381 wants to merge 1 commit into
Conversation
turn.cancel relied on the sink's on_turn_end callback (fired from _drop at turn exit) to clear the _active_turns slot, and awaited handle.result() assuming the sink had already dropped it. A cancelled turn can resolve before that callback runs, so the slot was sometimes left populated and the next turn.send hit a phantom turn_in_progress (-32003). Call clear_active from turn_cancel itself after the drain. pop is idempotent, so the sink's later clear is a harmless no-op. Co-authored-by: Claude (claude-opus-5) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
turn.cancel relied on the sink's on_turn_end callback (fired from _drop at turn exit) to clear the _active_turns slot, and awaited handle.result() assuming the sink had already dropped it. A cancelled turn can resolve before that callback runs, so the slot was sometimes left populated and the next turn.send hit a phantom turn_in_progress (-32003).
Call clear_active from turn_cancel itself after the drain. pop is idempotent, so the sink's later clear is a harmless no-op.
Type
Verification
uv run pytest tests/test_turn_cancel_clears_active.py -v-> 2 passeduv run ruff format(2 files unchanged),uv run ruff check(all passed)Risk
Related Issues
Fixes #115