fix: avoid manager flicker during instance polling#14
fix: avoid manager flicker during instance polling#14TBDevMaster wants to merge 2 commits intoEvolutionAPI:mainfrom
Conversation
There was a problem hiding this comment.
Sorry @TBDevMaster, your pull request is larger than the review limit of 150000 diff characters
|
Sourcery skipped this PR because the repository stores the manager as a built/minified bundle, so a very small functional change in The actual logic change is small: Before:
After:
In other words, the functional change is: // before
t({ isLoading: true, error: null })
// after
t((state) => ({ isLoading: !state.hasLoaded, error: null }))and successful/failed fetches now also set:
hasLoaded: true
This fixes the flicker reported in #11 while keeping the initial loading state intact. |
|
Integrated into develop in commit Heads up: this patches the built bundle directly ( Thank you for the contribution, @TBDevMaster! Closing as already merged. |
Summary
This fixes the manager UI flicker reported when the instances page refreshes every 5 seconds.
The issue happens because the instances polling path sets
isLoading: trueon everyfetchInstances()call. The manager page uses that flag to swap the whole list for skeleton cards, so each polling cycle causes a visible full-page flash.What changed
hasLoadedflag to the instances storeWhy this fixes the flicker
Before:
isLoading = trueisLoading = trueagainAfter:
isLoading = truehasLoaded = trueNotes
This repository currently includes the built manager bundle, so the change is applied in
manager/dist/assets/index-LD46dRLh.js.Closes #11.