MID-11015 Summarize operation results before task and trace storage#653
Open
kay1313 wants to merge 1 commit into
Open
MID-11015 Summarize operation results before task and trace storage#653kay1313 wants to merge 1 commit into
kay1313 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change reduces oversized functional trace and task result content by storing summarized
OperationResultbeans instead of full repetitive successful subresult trees.A new
OperationResultUtil.createStoredResultBean(...)helper clones the live result, enables successful-result summarization recursively, calls the existingOperationResult.summarize(true), and returns a storage-friendlyOperationResultType. The liveOperationResultis not mutated.The helper is used in:
TaskQuartzImpl.This keeps important root status and warning/error/fatal branches, while collapsing repeated successful low-level operations.
Related Prism PR:
That Prism change avoids large intermediate byte array allocation when writing ZIP entries and should be reviewed/merged together with this fix.
Testing
Tested with CSV import scenarios:
Observed reductions included:
245partial results /868kXML →20partial results /91kXML,1113partial results /3.6MBXML →80partial results /1.0MBXML,1294partial results /5.3MBXML →28partial results /1.2MBXML.Added test coverage for
OperationResultUtil.createStoredResultBean(...)to verify summarization, preservation of warning/error/fatal results, round-trip conversion, and no mutation of the source result.