Fix intermittent map icon sync on join and settings change

[Michael4d45]

Summary

• Fixes Intermittent issues with map icons #54 leftover bugs after the compass-check fix in Fix inverted compass check in MapManager map icon broadcast. #51:
  • Joiner missing the host icon when compass broadcast is on (host already sent HasMapIcon and never re-sends)
  • Host missing the joiner icon when AlwaysShowMapIcons is enabled (create timing / mid-session setting changes)
• Server replays map-icon state to joiners on connect and both ways on scene enter (icons are global, not scene-scoped)
• Client retries creating icons when the quick map opens if HasIcon was true but the GO was never created
• Mid-session AlwaysShow / compass setting changes force a local icon rebroadcast
• Temporary [MapIcon] Logger.Info lines on host/joiner for verification — intended to remove after confirm

Test plan

• Compass mode (AlwaysShowMapIcons off, both compasses equipped): joiner opens zoomed-in map and sees host icon without unequip/equip dance
• Same setup after joiner disconnect/reconnect
• /set globalmapicons true with both unequipped: host and joiner each see the other on zoomed-in map
• Grep BepInEx logs for [MapIcon] on host + joiner: expect sync (connect) / sync (scene-enter), client recv, and CreatePlayerIcon OK
• Confirm remote icons still do not appear on the large zoomed-out area map (intentional)
• After verification, strip TEMP [MapIcon] debug logs before merge if preferred

Made with Cursor