chore: establish incremental TS migration scaffolding and CI gate - #397
Merged
Conversation
birme
commented
Sep 4, 2026
birme
left a comment
Contributor
Author
There was a problem hiding this comment.
pr-reviewer verdict: APPROVE
PROOF: npm run build && npm test → 113 specs, 0 failures, 7 pending (identical to master baseline e9d9a5e — no behavior change).
- tsconfig:
allowJsstays on (mixed tree still compiles), only functional add isforceConsistentCasingInFileNames: true(safe hygiene, surfaced no errors).checkJs/strictcorrectly NOT enabled globally — the issue's "or equivalent" wording + documented deferral to per-file migration and #376 is a sound reading; enabling them now would break the build and violate the "builds cleanly / no behavior change" acceptance criteria. - CONTRIBUTING.md: contains (a) target strictness, (b) per-file conversion checklist, (c) note that global strict flags land in #376 — all three acceptance criteria met.
- No trademarks. Commit message format correct.
Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
engine/'s remaining JS modules can be converted to TypeScript one file at a time without breakingmaster.Changes
tsconfig.json: keepallowJs: true(mixed JS/TS tree already supported), addforceConsistentCasingInFileNames: true, and a comment recording thatcheckJs/strictare deliberately deferred (they land per-file, and globally only in the final slice chore: migrate jasmine spec suite to TypeScript and tighten compiler strictness #376). No globalcheckJs/strict— that would type-check 7,500 LOC of untyped JS and break the build.CONTRIBUTING.md: new "TypeScript migration" section — target strictness level, per-file conversion checklist (git mv .js→.ts, type exports, preserve public API/runtime behavior, build+test green, one module per commit), and the note that global strict flags land last in chore: migrate jasmine spec suite to TypeScript and tighten compiler strictness #376..github/workflows/nodejs.ymlalready runsnpm run build(tsc) on push, which is the type-check gate.Test plan
npm run build && npm test→ 113 specs, 0 failures, 7 pending (identical to baseline; no behavior change).Closes #372
🤖 Automated via Channel Engine Dev daily-backlog-pr skill