Skip to content

fix(security): bound NewSession.lineId and SdpAnswer length #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
birme wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(security): bound NewSession.lineId and SdpAnswer length #296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/api_validation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,6 +391,19 @@ describe('Input Validation', () => {
expect(response.statusCode).toBe(400);
});

test('rejects lineId exceeding 200 characters', async () => {
const response = await server.inject({
method: 'POST',
url: '/api/v1/session',
body: {
productionId: '1',
lineId: 'x'.repeat(201),
username: 'user'
}
});
expect(response.statusCode).toBe(400);
});

test('rejects username exceeding 200 characters', async () => {
const response = await server.inject({
method: 'POST',
Expand Down
4 changes: 2 additions & 2 deletions src/models.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ export const DetailedProductionResponse = Type.Object({

export const NewSession = Type.Object({
productionId: Type.String({ minLength: 1, pattern: '^[0-9]+$' }),
lineId: Type.String({ minLength: 1 }),
lineId: Type.String({ minLength: 1, maxLength: 200 }),
username: Type.String({ minLength: 1, maxLength: 200 })
});

Expand All @@ -316,7 +316,7 @@ export const SessionResponse = Type.Object({
});

export const SdpAnswer = Type.Object({
sdpAnswer: Type.String()
sdpAnswer: Type.String({ maxLength: 65536 })
});

export const ErrorResponse = Type.Object({
Expand Down
Loading