fix(security): validate ingestId param on ingest routes - #299
Open
birme wants to merge 1 commit into
Open
Conversation
Add TypeBox params schema (ingestId as a non-empty numeric string) to the GET, PATCH and DELETE /ingest/:ingestId routes so ingestId is validated by Fastify before parseInt, rejecting malformed input with 400. Closes #257 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
paramsschema (ingestIdas a non-empty numeric string,^[0-9]+$) to the GET, PATCH and DELETE/api/v1/ingests/:ingestIdroutes insrc/api_ingests.ts.ingestIdwas declared only as a TS generic with no Fastify schema, so it reachedparseIntunvalidated. Malformed input is now rejected with 400 before any handler logic runs.Test plan
npm run typecheckcleannpm test— 243/243 pass (worker teardown warning is pre-existing/expected)npm run lint— 0 errors (pre-existing warnings only)Closes #257