fix: clean up long-poll listener and timer on client disconnect

src/api_productions.test.ts

@@ -62,7 +62,7 @@
 const mockIngestManager = {
   load: jest.fn().mockResolvedValue(undefined),
   startPolling: jest.fn()
 } as any;
 
 const mockCoreFunctions = {
   getAllLinesResponse: jest.fn().mockImplementation((production) =>
@@ -177,7 +177,10 @@
     .fn()
     .mockImplementation((sessionId: string) => sessionId),
   createUserSession: jest.fn().mockResolvedValue(undefined),
-  getActiveUsers: jest.fn().mockResolvedValue([])
+  getActiveUsers: jest.fn().mockResolvedValue([]),
+  once: jest.fn(),
+  on: jest.fn(),
+  off: jest.fn()
 } as any;
 
 describe('Production API', () => {
@@ -492,13 +495,19 @@
             callback();
           }
         });
+      mockProductionManager.off = jest.fn();
       const response = await server.inject({
         method: 'POST',
         url: '/api/v1/production/1/line/1/participants'
       });
       expect(response.statusCode).toBe(200);
       const body = response.body ? JSON.parse(response.body) : [];
       expect(Array.isArray(body)).toBe(true);
+      // Cleanup must remove the 'users:change' listener on every exit path.
+      expect(mockProductionManager.off).toHaveBeenCalledWith(
+        'users:change',
+        expect.any(Function)
+      );
     });
     test('returns 500 when long poll fails due to internal error', async () => {
       const sessionsSpy = jest

src/api_productions.ts

@@ -918,19 +918,29 @@ const apiProductions: FastifyPluginCallback<ApiProductionsOptions> = (
       try {
         const timeoutMs = 25_000;
 
-        // Wait until either users:change fires or timeout expires
+        // Wait until users:change fires, the timeout expires, or the client
+        // disconnects. Cleanup runs once in every exit path so the listener and
+        // timer are always released and resolve is never called twice.
         await new Promise<void>((resolve) => {
-          const onChange = () => {
+          let settled = false;
+
+          const cleanup = () => {
+            if (settled) {
+              return;
+            }
+            settled = true;
             clearTimeout(timer);
+            productionManager.off('users:change', onChange);
+            request.raw.off('close', cleanup);
             resolve();
           };
 
-          const timer = setTimeout(() => {
-            productionManager.off('users:change', onChange);
-            resolve();
-          }, timeoutMs);
+          const onChange = () => cleanup();
+
+          const timer = setTimeout(cleanup, timeoutMs);
 
           productionManager.once('users:change', onChange);
+          request.raw.on('close', cleanup);
         });
 
         const { productionId, lineId } = request.params;

src/production_manager.ts

@@ -43,6 +43,10 @@ export class ProductionManager extends EventEmitter {
 
   constructor(dbManager: DbManager) {
     super();
+    // Long-poll endpoints register a transient 'users:change' listener per
+    // request, so concurrent pollers can exceed the default maxListeners (10)
+    // and emit spurious MaxListenersExceededWarning. Disable the limit.
+    this.setMaxListeners(0);
     this.dbManager = dbManager;
     this.userSessions = {};
   }