fix(security): reject scheme-relative /share paths, enforce origin - #307
Open
birme wants to merge 1 commit into
Open
fix(security): reject scheme-relative /share paths, enforce origin#307birme wants to merge 1 commit into
birme wants to merge 1 commit into
Conversation
…Host origin Closes #270 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /api/v1/sharebuilt a share URL from caller-suppliedpathvalidated only with TypeBoxpattern: '^/', which also matches scheme-relative (//evil.com/x) and backslash-prefixed (/\evil.com) values.new URL(path, publicHost)then resolves to an attacker-controlled origin, causing an open redirect in the returnedurland — more seriously — in theredirectUrlembedded in a minted OSC delegate token.ShareRequest.pathpattern insrc/models.tsto^/(?![/\\]).*so it requires a single leading/not followed by/or\(keepsmaxLength: 500).src/api_share.ts, afternew URL(req.body.path, opts.publicHost), assert the resolvedoriginequalsnew URL(opts.publicHost).originand reply 400 otherwise, guarding even if the schema is bypassed.Test plan
npm test) — 14 suites, 248 testsnpm run typecheck)npm run lint) — 0 errors//evil.com,/\evil.com,\\evil.com,https://evil.com, and no-slash paths rejected (400); valid paths like/mypath/to/sharestill return the correct same-origin URLCloses #270
🤖 Generated with Claude Code
Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com